fix: vec of contours size change, use len instead of capacity in dmesh#42
Merged
janhohenheim merged 5 commits intojanhohenheim:mainfrom Jan 29, 2026
Merged
fix: vec of contours size change, use len instead of capacity in dmesh#42janhohenheim merged 5 commits intojanhohenheim:mainfrom
janhohenheim merged 5 commits intojanhohenheim:mainfrom
Conversation
Owner
|
Looking at the original, this seems indeed to be the correct way. Thanks! Will merge when CI is green :) |
auto-merge was automatically disabled
December 9, 2025 16:53
Head branch was pushed to by a user without write access
Contributor
Author
|
Sorry for using the same PR, I can open a new one if needed. I havent realized its the same branch :/ In detail mesh I am encountering substract with overflow error on |
Owner
|
Took a little while to think this through, but yes, this looks correct, as the docs for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered
panicked at /rerecast-0.2.0/src/contours.rs:131:54: index out of bounds: the len is 275 but the index is 275which I assume is caused by wrong method to expand the vector capacity. Truncate seems to have no effect if we try to set the size larger than it is currently.