Test vec #792
Test vec #792
Conversation
This closes jank-lang#563.
| (aset arr 0 -1) | ||
| (is (= [-1 2 3] v))))) |
There was a problem hiding this comment.
Small nitpick, even though it's not required, it might be clearer that this mutation and the assertion are related if they were in a do block or logically grouped in some other way like doto). Not a big thing just weird to see mutating code in Clojure without a ! suffix, but I won't block on this
There was a problem hiding this comment.
I agree this mutable code is surprising but I don't see how to test this case differently. I wonder why aset is aset and not aset! 😅
clj-kondo warns of "redundant do" when adding a do under let.
I don't see how to apply doto here 🤔
There was a problem hiding this comment.
Oh yeah since you're testing v rather than arr in the assertion that wouldn't work, I'll drop the comment, thanks for checking
2 participants
This closes #563.