Enable clojure.string-test.reverse

[djblue]

Before:

% jank repl
user=> (require '[clojure.string :as str])
nil
user=> (str/reverse "hello")
"olleh"
user=> (str/reverse "🫲  hello 🫱")
"���� olleh  ����"

After:

% jank repl              
user=> (require '[clojure.string :as str])
nil
user=> (str/reverse "hello")
"olleh"
user=> (str/reverse "🫲  hello 🫱")
"🫱 olleh 🫲"

[jeaye]

Thank you, Chris!

[jeaye]

Thanks, Chris!

[jeaye]

Iterators do not have begin/end. Ranges do. These two things should not be conflated.

[jeaye]

Below, when you use this with a reverse view, what we actually want is utf8_range{ s } | .... So the fix here is to add a new struct utf8_range which holds a string and provides begin/end (and optionally rbegin/rend).

[djblue]

Sorry for all the code churn. I'm still learning about iterators + range based for loops. I think I finally landed in a good place. Initially we talked about having two separate iterators forwards/reverse, but it felt better if we could have one iterator that could go forwards and backwards.

[jeaye]

Nice!

[jeaye]

Merged jank-lang/clojure-test-suite#936. Want to pull that in here?

[djblue]

@jeaye when I bump to latest clojure-test-suite, existing enabled tests break. Should we address bumping clojure-test-suite in another PR, or should I disable the failing tests?

[jeaye]

@jeaye when I bump to latest clojure-test-suite, existing enabled tests break. Should we address bumping clojure-test-suite in another PR, or should I disable the failing tests?

Let's disable the failing tests.

[jeaye]

Nice!