-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rbac): add support for rejectUnauthorized in PG SSL options #1613
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thank you for this PR. Sorry that we are just now getting around to reviewing it. Had one comment that I wanted to get your opinion on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there is some overlap between the knex client and typeORMAdapter. So we can update to instead do something like the below. Which would allow us to no longer have to use custom code to resolve ssl.
adapter = await TypeORMAdapter.newAdapter({
type: 'postgres',
username: databaseConfig?.getString('connection.user'),
password: databaseConfig?.getString('connection.password'),
...knexClient.client.config.connection
});
What do you think?
Backstage's database configurations support various options that are being passed to the DB connection, example:
This PR adds support for rejectUnauthorized.