Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rbac): background color of sidebar in dark theme #1859

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ciiay
Copy link
Contributor

@ciiay ciiay commented Jul 2, 2024

RHIDP-3038: [RBAC] conditional Side bar styles are not changing for dark theme

How to test:

  1. Pull this PR to your local plugins repo
  2. Go to plugins/rbac and run yarn export-dynamic
  3. At your local showcase directory, go to dynamic-plugins-root/ and run
pkg=../../backstage-plugins/plugins/rbac
archive=$(npm pack $pkg)
tar -xzf "$archive" && rm "$archive"
mv package $(echo $archive | sed -e 's:\.tgz$::')
  1. Go to packages/backend/package.json and update rbac backend version to "@janus-idp/backstage-plugin-rbac-backend": "4.3.2" as current rbac plugin only works with the latest rbac backend version.
  2. Go to showcase root directory and run yarn install and yarn start to start backstage-showcase

@ciiay ciiay requested a review from a team as a code owner July 2, 2024 19:11
Copy link

openshift-ci bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kadel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ciiay ciiay force-pushed the rhidp-3038-fix-sidebar-bg-color-in-dark-thme branch from eac022d to 92f49e3 Compare July 5, 2024 19:16
@ciiay ciiay force-pushed the rhidp-3038-fix-sidebar-bg-color-in-dark-thme branch from 0351ee0 to bcf6ea3 Compare July 11, 2024 06:22
@ciiay ciiay requested review from jerolimov and removed request for kadel July 11, 2024 06:23
@ciiay ciiay force-pushed the rhidp-3038-fix-sidebar-bg-color-in-dark-thme branch from dd92855 to 98a5eab Compare July 11, 2024 21:43
@ciiay ciiay requested a review from invincibleJai July 11, 2024 21:43
@ciiay ciiay force-pushed the rhidp-3038-fix-sidebar-bg-color-in-dark-thme branch from 98a5eab to 34dffcc Compare July 12, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants