-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rbac): background color of sidebar in dark theme #1859
base: main
Are you sure you want to change the base?
fix(rbac): background color of sidebar in dark theme #1859
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eac022d
to
92f49e3
Compare
plugins/rbac/src/components/ConditionalAccess/ConditionalAccessSidebar.tsx
Outdated
Show resolved
Hide resolved
0351ee0
to
bcf6ea3
Compare
dd92855
to
98a5eab
Compare
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
98a5eab
to
34dffcc
Compare
RHIDP-3038: [RBAC] conditional Side bar styles are not changing for dark theme
How to test:
plugins/rbac
and runyarn export-dynamic
dynamic-plugins-root/
and runpackages/backend/package.json
and update rbac backend version to"@janus-idp/backstage-plugin-rbac-backend": "4.3.2"
as current rbac plugin only works with the latest rbac backend version.yarn install
andyarn start
to start backstage-showcase