Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix lint-staged on for new plugins #770

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

tumido
Copy link
Member

@tumido tumido commented Sep 20, 2023

After #466 lint-staged has issues when adding a new plugin. You end up with a cryptic error:

@janus-idp/shared-react:lint: ERROR: command finished with error: command (/Users/tcoufal/Programming/janus-idp/backstage-plugins/plugins/shared-react) yarn run lint -- --fix /Users/tcoufal/Programming/janus-idp/backstage-plugins/plugins/test/.eslintrc.js /Users/tcoufal/Programming/janus-idp/backstage-plugins/plugins/test/dev/index.tsx /Users/tcoufal/Programming/janus-idp/backstage-plugins/plugins/test/src/components/ExampleComponent/ExampleComponent.test.tsx /Users/tcoufal/Programming/janus-idp/backstage-plugins/plugins/test/src/components/ExampleComponent/ExampleComponent.tsx /Users/tcoufal/Programming/janus-idp/backstage-plugins/plugins/test/src/components/ExampleComponent/index.ts /Users/tcoufal/Programming/janus-idp/backstage-plugins/plugins/test/src/components/ExampleFetchComponent/ExampleFetchComponent.test.tsx /Users/tcoufal/Programming/janus-idp/backstage-plugins/plugins/test/src/components/ExampleFetchComponent/ExampleFetchComponent.tsx /Users/tcoufal/Programming/janus-idp/backstage-plugins/plugins/test/src/components/ExampleFetchComponent/index.ts /Users/tcoufal/Programming/janus-idp/backstage-plugins/plugins/test/src/index.ts /Users/tcoufal/Programming/janus-idp/backstage-plugins/plugins/test/src/plugin.test.ts /Users/tcoufal/Programming/janus-idp/backstage-plugins/plugins/test/src/plugin.ts /Users/tcoufal/Programming/janus-idp/backstage-plugins/plugins/test/src/routes.ts /Users/tcoufal/Programming/janus-idp/backstage-plugins/plugins/test/src/setupTests.ts exited (1)

from any random package in the monorepo (depends on which one is run the firsqt). I suspect this has something to do with vercel/turborepo#3364 and creating a tooling chain

husky -> npm -> lint-staged -> yarn -> turbo -> backstage-cli -> eslint

This PR should simplify the chain by removing one step and removing one tool to:

husky -> yarn -> lint-stage -> turbo -> backstage-cli -> eslint

PTAL

@schultzp2020

@tumido tumido requested a review from a team as a code owner September 20, 2023 13:04
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tumido tumido merged commit 363ddfd into janus-idp:main Sep 21, 2023
6 checks passed
@tumido tumido deleted the fix-lint-staged branch September 21, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants