Fixing rbac tests execution #1248
Conversation
|
|
||
| droute_send $release_name $project | ||
|
|
||
| exit ${RESULT} | ||
| echo ${RESULT} |
There was a problem hiding this comment.
We should return and exit as per the result else it will not mark job as failed because of set -e while running tests.
There was a problem hiding this comment.
@subhashkhileri ok it's just for test purpose, let's see if rbac tests will be executed
Update openshift-ci-tests.sh to echo RESULT Changed the behavior in openshift-ci-tests.sh to echo the result instead of exiting the script using the RESULT variable. This modification allows further actions or analysis after the droute_send function call. Signed-off-by: Gustavo Lira <[email protected]>
gustavolira
force-pushed
the
fix-rbac-tests-execution
branch
from
3bf87da
to
308e086
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
The image is available at: |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Update openshift-ci-tests.sh to echo RESULT
Changed the behavior in openshift-ci-tests.sh to echo the result instead of exiting the script using the RESULT variable. This modification allows further actions or analysis after the droute_send function call.
Which issue(s) does this PR fix
RBAC tests execution
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer