Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow replacing core plugins #1256

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Allow replacing core plugins #1256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e38ba85
Allow overriding core frontend plugins
davidfestal May 13, 2024
5e88e91
Allow overriding core backend plugins
davidfestal May 13, 2024
8893592
Run prettier
davidfestal May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
121 changes: 78 additions & 43 deletions packages/app/src/components/AppBase/AppBase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,59 +30,94 @@ const AppBase = () => {
entityTabOverrides,
scaffolderFieldExtensions,
} = useContext(DynamicRootContext);

const ifNotDynamic = (path: string, route: React.ReactElement) =>
dynamicRoutes.filter(({ path: p }) => p === path).length === 0 && route;

return (
<AppProvider>
<AlertDisplay />
<OAuthRequestDialog />
<AppRouter>
<Root>
<FlatRoutes>
{dynamicRoutes.filter(({ path }) => path === '/').length === 0 && (
{ifNotDynamic(
'/',
<Route path="/" element={<HomepageCompositionRoot />}>
<HomePage />
</Route>
</Route>,
)}
{ifNotDynamic(
'/catalog',
<Route
path="/catalog"
element={<CatalogIndexPage pagination />}
/>,
)}
{ifNotDynamic(
'//catalog/:namespace/:kind/:name',
<Route
path="/catalog/:namespace/:kind/:name"
element={<CatalogEntityPage />}
>
{entityPage(entityTabOverrides)}
</Route>,
)}
{ifNotDynamic(
'/create',
<Route
path="/create"
element={
<ScaffolderPage
headerOptions={{ title: 'Software Templates' }}
/>
}
>
<ScaffolderFieldExtensions>
{scaffolderFieldExtensions.map(
({ scope, module, importName, Component }) => (
<Component key={`${scope}-${module}-${importName}`} />
),
)}
</ScaffolderFieldExtensions>
scaffolderFieldExtensions
</Route>,
)}
{ifNotDynamic(
'/api-docs',
<Route path="/api-docs" element={<ApiExplorerPage />} />,
)}
{ifNotDynamic(
'/catalog-import',
<Route
path="/catalog-import"
element={
<RequirePermission permission={catalogEntityCreatePermission}>
<CatalogImportPage />
</RequirePermission>
}
/>,
)}
{ifNotDynamic(
'/search',
<Route path="/search" element={<BackstageSearchPage />}>
<SearchPage />
</Route>,
)}
{ifNotDynamic(
'/settings',
<Route path="/settings" element={<UserSettingsPage />}>
{settingsPage}
</Route>,
)}
{ifNotDynamic(
'/catalog-graph',
<Route path="/catalog-graph" element={<CatalogGraphPage />} />,
)}
{ifNotDynamic(
'/learning-paths',
<Route path="/learning-paths" element={<LearningPaths />} />,
)}
<Route path="/catalog" element={<CatalogIndexPage pagination />} />
<Route
path="/catalog/:namespace/:kind/:name"
element={<CatalogEntityPage />}
>
{entityPage(entityTabOverrides)}
</Route>
<Route
path="/create"
element={
<ScaffolderPage
headerOptions={{ title: 'Software Templates' }}
/>
}
>
<ScaffolderFieldExtensions>
{scaffolderFieldExtensions.map(
({ scope, module, importName, Component }) => (
<Component key={`${scope}-${module}-${importName}`} />
),
)}
</ScaffolderFieldExtensions>
scaffolderFieldExtensions
</Route>
<Route path="/api-docs" element={<ApiExplorerPage />} />
<Route
path="/catalog-import"
element={
<RequirePermission permission={catalogEntityCreatePermission}>
<CatalogImportPage />
</RequirePermission>
}
/>
<Route path="/search" element={<BackstageSearchPage />}>
<SearchPage />
</Route>
<Route path="/settings" element={<UserSettingsPage />}>
{settingsPage}
</Route>
<Route path="/catalog-graph" element={<CatalogGraphPage />} />
<Route path="/learning-paths" element={<LearningPaths />} />
<Route path="/admin" element={<AdminPage />} />
{dynamicRoutes
.filter(({ path }) => path.startsWith('/admin'))
Expand Down
26 changes: 16 additions & 10 deletions packages/backend/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,22 +67,28 @@ backend.add(dynamicPluginsFrontendSchemas());
backend.add(customLogger());

backend.add(import('@backstage/plugin-app-backend/alpha'));
backend.add(
import('@backstage/plugin-catalog-backend-module-scaffolder-entity-model'),
);

backend.add(import('@backstage/plugin-catalog-backend/alpha'));
if (process.env.DISABLE_STANDARD_CATALOG !== 'true') {
backend.add(
import('@backstage/plugin-catalog-backend-module-scaffolder-entity-model'),
);
backend.add(import('@backstage/plugin-catalog-backend/alpha'));

// TODO: Probably we should now provide this as a dynamic plugin
backend.add(import('@backstage/plugin-catalog-backend-module-openapi'));
// TODO: Probably we should now provide this as a dynamic plugin
backend.add(import('@backstage/plugin-catalog-backend-module-openapi'));
}

backend.add(import('@backstage/plugin-proxy-backend/alpha'));

// TODO: Check in the Scaffolder new backend plugin why the identity is not passed and the default is built instead.
backend.add(import('@backstage/plugin-scaffolder-backend/alpha'));
if (process.env.DISABLE_STANDARD_SCAFFOLDER !== 'true') {
// TODO: Check in the Scaffolder new backend plugin why the identity is not passed and the default is built instead.
backend.add(import('@backstage/plugin-scaffolder-backend/alpha'));
}

backend.add(import('@backstage/plugin-search-backend/alpha'));
backend.add(import('@backstage/plugin-search-backend-module-catalog/alpha'));
if (process.env.DISABLE_STANDARD_SEARCH !== 'true') {
backend.add(import('@backstage/plugin-search-backend/alpha'));
backend.add(import('@backstage/plugin-search-backend-module-catalog/alpha'));
}

// TODO: We should test it more deeply. The structure is not exactly the same as the old backend implementation
backend.add(import('@backstage/plugin-events-backend/alpha'));
Expand Down
Loading