Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update to node 20.12.12 #1293

Closed
wants to merge 1 commit into from
Closed

chore(deps): update to node 20.12.12 #1293

wants to merge 1 commit into from

Conversation

nickboldt
Copy link
Member

What does this PR do?

chore(deps): update to node 20.12.12; ubi9 nodejs-20 containers have node 20.12.2-2 (rhel 9.4), so this should be equivalent?

Signed-off-by: Nick Boldt [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…node 20.12.2-2 (rhel 9.4), so this should be equivalent?

Signed-off-by: Nick Boldt <[email protected]>
@nickboldt nickboldt requested a review from a team as a code owner June 4, 2024 00:13
Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nickboldt
Copy link
Member Author

replacement for #1043 which attempts to move to 20.14, which is definitely newer than the ubi9 containers.

@nickboldt nickboldt changed the title chore(deps): update to node 20.12.12; ubi9... chore(deps): update to node 20.12.12 Jun 4, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1293!

@jerolimov
Copy link
Member

/retest

Copy link

openshift-ci bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BethGriggs
Once this PR has been reviewed and has the lgtm label, please ask for approval from nickboldt. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kim-tsao
Copy link
Member

superseded by #1378

@kim-tsao kim-tsao closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants