Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deps): update to backstage 1.27 #1325

Merged
merged 13 commits into from
Jul 10, 2024
Merged

feat(deps): update to backstage 1.27 #1325

merged 13 commits into from
Jul 10, 2024

Conversation

schultzp2020
Copy link
Member

Description

Confirm plugin updates work:

  • Techdocs
  • GitLab Org

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@schultzp2020 schultzp2020 requested a review from a team as a code owner June 14, 2024 16:52
@schultzp2020 schultzp2020 marked this pull request as draft June 14, 2024 16:53
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1325!

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1325!

@Zaperex
Copy link
Member

Zaperex commented Jun 17, 2024

As mentioned in the patch for the plugin-app-backend package, we can remove the patch file for @backstage/plugin-app-backend since this PR upgrades the dependency to 0.3.67 which has the required changes.

Zaperex and others added 2 commits June 17, 2024 08:27
@Zaperex
chore(patches): update patches to 1.27.7 (#1330)
0b201ba 
* chore: remove outdated patches

Signed-off-by: Frank Kong <[email protected]>

* chore: update scaffolder audit logging and permission patches to 1.27.7

Signed-off-by: Frank Kong <[email protected]>

* chore: remove unnecessary plugin-app-backend patch

Signed-off-by: Frank Kong <[email protected]>

---------

Signed-off-by: Frank Kong <[email protected]>
@schultzp2020
Merge branch 'main' into rhidp-2334
33b9bf5
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1325!

@schultzp2020 schultzp2020 marked this pull request as ready for review June 17, 2024 14:02
@schultzp2020
Copy link
Member Author

/retest

@nickboldt
Copy link
Member

/lgtm

other than the usual prow failures :this-is-fine:

@openshift-ci openshift-ci bot added the lgtm label Jun 17, 2024
@nickboldt
Copy link
Member

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@subhashkhileri
Copy link
Member

/test e2e-tests

nickboldt
nickboldt reviewed Jun 19, 2024
View reviewed changes
Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it but what do we think about the never-passing prow jobs?

https://media.giphy.com/media/mx9fVEF08tyne/giphy.gif

(great, now that song is stuck in my head...)

@nickboldt
Copy link
Member

/test e2e-tests

@openshift-ci openshift-ci bot removed the lgtm label Jun 24, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 24, 2024

New changes are detected. LGTM label has been removed.

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1325!

@schultzp2020
find issue
b35884d 
Signed-off-by: Paul Schultz <[email protected]>
@schultzp2020
update dist dynamic
47fc01e 
Signed-off-by: Paul Schultz <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1325!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1325!

@nickboldt nickboldt merged commit 4c1ee5d into main Jul 10, 2024
7 of 8 checks passed
@nickboldt nickboldt deleted the rhidp-2334 branch July 10, 2024 12:24
@jesuino jesuino mentioned this pull request Jul 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickboldt nickboldt nickboldt left review comments

@gashcrumb gashcrumb Awaiting requested review from gashcrumb

@PatAKnight PatAKnight Awaiting requested review from PatAKnight

@davidfestal davidfestal Awaiting requested review from davidfestal

@Zaperex Zaperex Awaiting requested review from Zaperex

Assignees

@nickboldt nickboldt

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@schultzp2020 @Zaperex @nickboldt @subhashkhileri @openshift-merge-robot