Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add steps on how to test proxy on OCP #1331

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kadel
Copy link
Member

@kadel kadel commented Jun 17, 2024

add steps on how to test proxy on OCP

add steps on how to test proxy on OCP
@kadel kadel requested a review from a team as a code owner June 17, 2024 11:24
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI seems to be failing on formatting issues in this file: https://github.com/janus-idp/backstage-showcase/pull/1331/checks#step:7:14

LGTM otherwise. Thanks for providing the instructions for OpenShift.

Copy link

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rm3l
Once this PR has been reviewed and has the lgtm label, please ask for approval from kadel. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants