-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test automation] Configure and verify GitHub integration with Org data fetching #1336
Conversation
The image is available at: |
merge main fork with omar fork
The image is available at: |
@subhashkhileri can you provide a review? Thanks! |
/retest |
2 similar comments
/retest |
/retest |
The image is available at: |
/lgtm |
/lgtm cancel |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@josephca @Omar-AlJaljuli This test is already covered in github happy path : https://github.com/janus-idp/backstage-showcase/blob/main/e2e-tests/playwright/e2e/github-happy-path.spec.ts#L46 you would like to enhance or update the existing test or remove from old and keep it like this? |
@subhashkhileri I believe the test you're talking about (in github happy path) tests the fetching of components from repos that have something like a catalog-info.yaml file Documentation for whats being tested in GH happy path. This PR tests if the organization that was integrated with is visible with the right config Documentation for whats being tested by this PR |
@subhashkhileri @Omar-AlJaljuli I think Omar is right. For example, the 'github happy path' is getting the group from
|
Description
Configured the environment to integrate the Janus-qe organization into the catalog. Created an automated test file that checks if the integration works. https://issues.redhat.com/browse/RHIDP-753.
Configuration followed from: https://access.redhat.com/documentation/en-us/red_hat_developer_hub/1.1/html-single/getting_started_with_red_hat_developer_hub/index#proc-add-source-control-rhdh-catalog_rhdh-getting-started
Which issue(s) does this PR fix
RHIDP-753
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer