Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test automation] Configure and verify GitHub integration with Org data fetching #1336

Merged
merged 6 commits into from
Jul 8, 2024

Conversation

Omar-AlJaljuli
Copy link
Contributor

Description

Configured the environment to integrate the Janus-qe organization into the catalog. Created an automated test file that checks if the integration works. https://issues.redhat.com/browse/RHIDP-753.

Configuration followed from: https://access.redhat.com/documentation/en-us/red_hat_developer_hub/1.1/html-single/getting_started_with_red_hat_developer_hub/index#proc-add-source-control-rhdh-catalog_rhdh-getting-started

Which issue(s) does this PR fix

RHIDP-753

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@Omar-AlJaljuli Omar-AlJaljuli requested a review from a team as a code owner June 20, 2024 15:16
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1336!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1336!

@josephca josephca requested review from subhashkhileri and removed request for rnapoles-rh June 24, 2024 19:21
@josephca
Copy link
Contributor

@subhashkhileri can you provide a review? Thanks!

@Omar-AlJaljuli
Copy link
Contributor Author

/retest

2 similar comments
@Omar-AlJaljuli
Copy link
Contributor Author

/retest

@Omar-AlJaljuli
Copy link
Contributor Author

/retest

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1336!

@subhashkhileri
Copy link
Member

/lgtm

@subhashkhileri
Copy link
Member

/lgtm cancel

@openshift-ci openshift-ci bot removed the lgtm label Jun 28, 2024
Copy link

openshift-ci bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from subhashkhileri. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved label Jun 28, 2024
@subhashkhileri
Copy link
Member

@josephca @Omar-AlJaljuli This test is already covered in github happy path : https://github.com/janus-idp/backstage-showcase/blob/main/e2e-tests/playwright/e2e/github-happy-path.spec.ts#L46

you would like to enhance or update the existing test or remove from old and keep it like this?

@Omar-AlJaljuli
Copy link
Contributor Author

Omar-AlJaljuli commented Jun 28, 2024

@josephca @Omar-AlJaljuli This test is already covered in github happy path : https://github.com/janus-idp/backstage-showcase/blob/main/e2e-tests/playwright/e2e/github-happy-path.spec.ts#L46

you would like to enhance or update the existing test or remove from old and keep it like this?

@subhashkhileri I believe the test you're talking about (in github happy path) tests the fetching of components from repos that have something like a catalog-info.yaml file Documentation for whats being tested in GH happy path. This PR tests if the organization that was integrated with is visible with the right config Documentation for whats being tested by this PR

@josephca
Copy link
Contributor

josephca commented Jul 8, 2024

@josephca @Omar-AlJaljuli This test is already covered in github happy path : https://github.com/janus-idp/backstage-showcase/blob/main/e2e-tests/playwright/e2e/github-happy-path.spec.ts#L46
you would like to enhance or update the existing test or remove from old and keep it like this?

@subhashkhileri I believe the test you're talking about (in github happy path) tests the fetching of components from repos that have something like a catalog-info.yaml file Documentation for whats being tested in GH happy path. This PR tests if the organization that was integrated with is visible with the right config Documentation for whats being tested by this PR

@subhashkhileri @Omar-AlJaljuli I think Omar is right. For example, the 'github happy path' is getting the group from

- not from the 'githubOrg'.

@josephca josephca merged commit 8ff97cd into janus-idp:main Jul 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants