Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Link Scaffolded Templates to Catalog Items #1362

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

subhashkhileri
Copy link
Member

Description

[e2e] Link Scaffolded Templates to Catalog Items

Which issue(s) does this PR fix

https://issues.redhat.com/browse/RHIDP-2078
https://issues.redhat.com/browse/RHIDP-2077

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@subhashkhileri subhashkhileri requested a review from a team as a code owner June 28, 2024 16:07
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1362!

Copy link
Contributor

github-actions bot commented Jul 1, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1362!

@subhashkhileri
Copy link
Member Author

/retest

Copy link
Contributor

github-actions bot commented Jul 1, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1362!

@subhashkhileri
Copy link
Member Author

/retest

2 similar comments
@subhashkhileri
Copy link
Member Author

/retest

@subhashkhileri
Copy link
Member Author

/retest

Copy link
Contributor

github-actions bot commented Jul 2, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1362!

Copy link
Contributor

@josephca josephca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jul 10, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Jul 10, 2024
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1362!

@subhashkhileri
Copy link
Member Author

/test e2e-tests

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1362!

Copy link

openshift-ci bot commented Jul 11, 2024

@subhashkhileri: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 98dbe28 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants