Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add catalog-backend patch with endpoint audit logging #1383

Merged

Conversation

Zaperex
Copy link
Member

@Zaperex Zaperex commented Jul 10, 2024

Description

Adds a patch containing the audit logging changes in redhat-developer/backstage#9

Successor of #1375

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Jul 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1383!

@Zaperex Zaperex marked this pull request as ready for review July 11, 2024 18:44
@Zaperex Zaperex requested a review from a team as a code owner July 11, 2024 18:44
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1383!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1383!

Copy link
Member

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link

openshift-ci bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: schultzp2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4fac227 into janus-idp:main Jul 15, 2024
7 checks passed
@Zaperex Zaperex deleted the add-catalog-audit-logging-patches branch July 15, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants