-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kiali): add kiali dynamic plugin #902
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The image is available at: |
The image is available at: |
The image is available at: |
|
The image is available at: |
The image is available at: |
1 similar comment
The image is available at: |
The image is available at: |
@christophe-f Do we really want to embed such a new plugin in the RHDH image and add a fixed new tab ? |
|
we have customers already using the plugin (menu view) like dynamic plugin but they requested us to have some view for entity perspective We did the plugin in https://github.com/janus-idp/backstage-plugins/tree/main/plugins/kiali some time ago (9 months) but we didn't know that we have to add the plugin here to see kiali in the entity view |
The image is available at: |
This shouldn't be. It's related to a limitation in the dynamic plugins support. We've just been discussing with @christophe-f that we should drop this limitation asap. |
Issue #1160 was opened for this purpose. |
With #1173 it will be possible to configure new tabs as needed in configuration. Would you be willing to try this solution and see if this works for you? |
If this work and it will be for next june release for us is fine. Anyway where is the place to add docs and kiali in RHDH docs? This is going to be a Openshift servicemesh plugin for customers supported and we want to include it |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
Add kiali plugin to showcase
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer
1- In your local
backstage-plugins/plugins/kiali
andbackstage-plugins/plugins/kiali-backend
, runyarn export-dynamic
to export RBAC plugin UI as a dynamic plugin2 -In your local
backstage-showcase/dynamic-plugins-root/
directory, run the below command to install RBAC plugin UIThe result in folder dynamic-plugins-root should be something like this
janus-idp-backstage-plugin-kiali-1.14.1
janus-idp-backstage-plugin-kiali-backend-1.10.1
3- In your local
backstage-showcase/app-config.local.yaml
file, add the below changes4- In dynamic-plugins.default.yaml file Line 596, and Line 619 change disabled value to disabled: false to enable RBAC plugin UI.
5 - Add a component with the annotation
backstage.io/kubernetes-namespace
6 - Start Backend-showcase app, and observe that Kiali button shows on the left side menu and the entity tab.