Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): add tag filtering and searchbar #90

Merged
merged 8 commits into from
Jun 21, 2023
Merged

Conversation

schultzp2020
Copy link
Member

@schultzp2020 schultzp2020 commented Jun 13, 2023

What does this PR do / why we need it

Adds tag filtering and searchbar

localhost_3000_plugins

Which issue(s) does this PR fix

Fixes #83

PR acceptance criteria

  • Unit Tests
  • E2E Tests
  • Documentation

How to test changes / Special notes to the reviewer

Signed-off-by: Paul Schultz <[email protected]>

fix:(monorepo): enable tailwind prettier plugin (#89)

Signed-off-by: Paul Schultz <[email protected]>

fix(website): store fonts locally (#88)

Signed-off-by: Paul Schultz <[email protected]>

(wip) searchbar

Signed-off-by: Paul Schultz <[email protected]>

finish searchbar styling

Signed-off-by: Paul Schultz <[email protected]>

feat(website): add tag filtering and searchbar

Signed-off-by: Paul Schultz <[email protected]>
@schultzp2020 schultzp2020 marked this pull request as draft June 13, 2023 21:34
@schultzp2020 schultzp2020 marked this pull request as ready for review June 13, 2023 21:38
<h3>{title}</h3>
<p className="line-clamp-3">{description}</p>
</div>
<div className="bg-pf-cyan-300 w-fit rounded px-2 py-1 text-sm text-white">{category}</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The tag on the plugin tile looks more like a button to me than a "tag" information. Also since "Frontend" and "Backend" strings look so similar when you glance over them it doesn't help me with quick orientation.

WDYT about changing this to a small React icon (for frontend), NodeJS icon (for backend) and some arbirtrary "action" or "automation" icon (for scaffolder actions) instead? All with tooltips.

Something like this? WDYT?
image

Copy link
Member Author

@schultzp2020 schultzp2020 Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea. Thoughts @serenamarie125?

localhost_3000_plugins (1)

@serenamarie125
Copy link
Contributor

is there a tooltip as well? so people can know how that is associated to the filter?
What icon do we use for action?

@schultzp2020
Copy link
Member Author

schultzp2020 commented Jun 15, 2023

is there a tooltip as well? so people can know how that is associated to the filter? What icon do we use for action?

A gear icon: the size and color will be the same as the other icons

image

Whoops, I need to add a tooltip

@schultzp2020
Copy link
Member Author

schultzp2020 commented Jun 15, 2023

image
image

Signed-off-by: Paul Schultz <[email protected]>
@christophe-f
Copy link
Contributor

Something like this with tags/labels would be cool
Screenshot 2023-06-15 at 2 43 17 PM

We could say frontend/backstage/actions but also a category like Auth/OCI etc

Ie https://docusaurus.io/showcase

@schultzp2020
Copy link
Member Author

schultzp2020 commented Jun 15, 2023

Something like this with tags/labels would be cool Screenshot 2023-06-15 at 2 43 17 PM

We could say frontend/backstage/actions but also a category like Auth/OCI etc

Ie https://docusaurus.io/showcase

I know @serenamarie125 mentioned that we should add a tag system like backstage sooner or later. I can create an issue to track this.

image

Edit: #122

Copy link
Contributor

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@schultzp2020 schultzp2020 requested a review from tumido June 20, 2023 14:10
"@segment/analytics-next": "1.53.0",
"clsx": "1.2.1",
"deepmerge": "4.3.1",
"encoding": "0.1.13",
"feed": "4.2.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't feed used to provide a RSS feed for the blogs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were fragments from the old website (no longer needed).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Comment on lines +23 to +25
"@radix-ui/react-dropdown-menu": "2.0.5",
"@radix-ui/react-form": "0.0.3",
"@radix-ui/react-tooltip": "1.0.6",
Copy link
Contributor

@christophe-f christophe-f Jun 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are using Tailwindcss, do we need Radix-ui?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Radix-UI is a headless UI component library (the components have no styling) that has a focus on ease of use and accessibility. Therefore, all I need to do with Radix-UI is the styling the individual components rather than needing to add the required logic and accessibility for these components. Here is their website.

@schultzp2020 schultzp2020 merged commit 34eb5b1 into main Jun 21, 2023
1 check passed
@schultzp2020 schultzp2020 deleted the issue-83 branch June 21, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a tag filtering mechanism to the plugin page
4 participants