Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Recreate Backstage Pod on changes of ConfigMaps/Secrets configured in CR #351

Merged
merged 17 commits into from
May 21, 2024
Merged

Recreate Backstage Pod on changes of ConfigMaps/Secrets configured in CR #351

merged 17 commits into from
May 21, 2024

Conversation

gazarenkov
Copy link
Member

Description

This pull-request added following functionality:

  • Adds label and annotation to ConfigMaps/Secrets configured in Backstage CR.
  • By default rhdh.redhat.com/ext-config-sync=true which allow controller watch ConfigMaps/Secrets
  • Enqueuing function calculates hash of the data, compares it with saved in the deployment's pod template annotation and calls reconcile in case they do not match (configuration changed)
  • Since Pod template is changed k8s restarting it and reconciliation function saves new hash for the next cycle.

Which issue(s) does this PR fix or relate to

#236

PR acceptance criteria

  • Tests
  • Documentation TBD, scratched in the issue comments

How to test changes / Special notes to the reviewer

  • Create Backstage CR with configuration
  • Create ConfigMap(s)/Secret(s) referenced in CR
  • Check if Operator added label rhdh.redhat.com/ext-config-sync=true and annotation rhdh.redhat.com/backstage-name=
  • Make sure Backstage instance is running
  • Change anything in the data field of CMs/Secrets
  • Make sure Backstage started recreating the Pod
  • Make sure files/env vars with new content mounted to backstage container

@openshift-ci openshift-ci bot requested review from nickboldt and rm3l May 2, 2024 09:15
@gazarenkov gazarenkov requested review from kadel and removed request for nickboldt May 2, 2024 09:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024

⚠️ Files changed in bundle generation!

Those changes to the operator bundle manifests should have been pushed automatically to your PR branch.
You might also need to manually update the .rhdh/bundle/manifests/rhdh-operator.csv.yaml CSV file accordingly.

@gazarenkov gazarenkov requested a review from coreydaley May 2, 2024 12:30
coreydaley
coreydaley suggested changes May 7, 2024
View reviewed changes
bundle/manifests/backstage-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
controllers/backstage_controller.go Outdated Show resolved Hide resolved
controllers/backstage_controller.go Outdated Show resolved Hide resolved
pkg/model/runtime_test.go Outdated Show resolved Hide resolved
pkg/model/runtime_test.go Outdated Show resolved Hide resolved
pkg/model/runtime_test.go Outdated Show resolved Hide resolved
pkg/model/externalconfig.go Show resolved Hide resolved
integration_tests/suite_test.go Outdated Show resolved Hide resolved
integration_tests/suite_test.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

PR images are available:

  1. https://quay.io/janus-idp/operator:0.2.0-pr-351-7a31f97
  2. https://quay.io/janus-idp/operator-bundle:0.2.0-pr-351-7a31f97
  3. https://quay.io/janus-idp/operator-catalog:0.2.0-pr-351-7a31f97

@gazarenkov
small fixes
15a0be2 
Signed-off-by: gazarenkov <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

PR images are available:

  1. https://quay.io/janus-idp/operator:0.2.0-pr-351-15a0be2
  2. https://quay.io/janus-idp/operator-bundle:0.2.0-pr-351-15a0be2
  3. https://quay.io/janus-idp/operator-catalog:0.2.0-pr-351-15a0be2

@gazarenkov
add comment
6246915 
Signed-off-by: gazarenkov <[email protected]>
@gazarenkov gazarenkov requested a review from coreydaley May 8, 2024 06:40
@gazarenkov
test preprocessor
685761e 
Signed-off-by: gazarenkov <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

PR images are available:

  1. https://quay.io/janus-idp/operator:0.2.0-pr-351-685761e
  2. https://quay.io/janus-idp/operator-bundle:0.2.0-pr-351-685761e
  3. https://quay.io/janus-idp/operator-catalog:0.2.0-pr-351-685761e

rm3l
rm3l reviewed May 21, 2024
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Small comment about the permissions in the RHDH CSV..

.rhdh/bundle/manifests/rhdh-operator.csv.yaml Outdated Show resolved Hide resolved
controllers/preprocessor_test.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

PR images are available:

  1. https://quay.io/janus-idp/operator:0.2.0-pr-351-eaba66b
  2. https://quay.io/janus-idp/operator-bundle:0.2.0-pr-351-eaba66b
  3. https://quay.io/janus-idp/operator-catalog:0.2.0-pr-351-eaba66b

@rm3l rm3l mentioned this pull request May 21, 2024
Closed
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Files changed in bundle generation!

Those changes to the operator bundle manifests should have been pushed automatically to your PR branch.
You might also need to manually update the .rhdh/bundle/manifests/rhdh-operator.csv.yaml CSV file accordingly.

@github-actions GitHub Actions
Copy link
Contributor

PR images are available:

  1. https://quay.io/janus-idp/operator:0.2.0-pr-351-aecd825
  2. https://quay.io/janus-idp/operator-bundle:0.2.0-pr-351-aecd825
  3. https://quay.io/janus-idp/operator-catalog:0.2.0-pr-351-aecd825

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

PR images are available:

  1. https://quay.io/janus-idp/operator:0.2.0-pr-351-aecd825
  2. https://quay.io/janus-idp/operator-bundle:0.2.0-pr-351-aecd825
  3. https://quay.io/janus-idp/operator-catalog:0.2.0-pr-351-aecd825

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

PR images are available:

  1. https://quay.io/janus-idp/operator:0.2.0-pr-351-90bea8e
  2. https://quay.io/janus-idp/operator-bundle:0.2.0-pr-351-90bea8e
  3. https://quay.io/janus-idp/operator-catalog:0.2.0-pr-351-90bea8e

@gazarenkov gazarenkov requested a review from rm3l May 21, 2024 11:32
@openshift-ci openshift-ci bot added the lgtm PR is ready to be merged. Required by Prow. label May 21, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved PR has been approved by an approver from all required OWNERS files. Required by Prow. label May 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 806c5af into janus-idp:main May 21, 2024
8 checks passed
@gazarenkov gazarenkov deleted the refresh_config branch June 6, 2024 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rm3l rm3l rm3l approved these changes

@kadel kadel Awaiting requested review from kadel

@coreydaley coreydaley Awaiting requested review from coreydaley

Assignees

@rm3l rm3l

@coreydaley coreydaley

Labels
approved PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gazarenkov @rm3l @coreydaley