This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
Fix the RBAC permissions of the Operator in the RHDH CSV #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be kept in sync with the CSV file in 'bundle/manifests/backstage-operator.clusterserviceversion.yaml'
rm3l
changed the title
rm3l
requested review from
nickboldt,
gazarenkov and
coreydaley
and removed request for
kadel and
jianrongzhang89
rm3l
force-pushed
the
360-setting-custom-spec.application.route.host-not-working-using-the-rhdh-operator-on-openshift-due-to-inconsistent-permissions-between-rhdh-and-backstage-csvs
branch
from
e4f35e5
to
b26032b
Compare
gazarenkov
reviewed
May 16, 2024
rm3l
force-pushed
the
360-setting-custom-spec.application.route.host-not-working-using-the-rhdh-operator-on-openshift-due-to-inconsistent-permissions-between-rhdh-and-backstage-csvs
branch
from
b26032b
to
c36d734
Compare
|
gazarenkov
approved these changes
May 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gazarenkov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
rm3l
deleted the
360-setting-custom-spec.application.route.host-not-working-using-the-rhdh-operator-on-openshift-due-to-inconsistent-permissions-between-rhdh-and-backstage-csvs
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a difference in the RBAC permissions of the operator between the CSV used for RHDH (https://github.com/janus-idp/operator/blob/main/.rhdh/bundle/manifests/rhdh-operator.csv.yaml) and the upstream one (https://github.com/janus-idp/operator/blob/main/bundle/manifests/backstage-operator.clusterserviceversion.yaml).
This causes issues like the one reported in #360.
Which issue(s) does this PR fix or relate to
spec.application.route.hostnot working using the RHDH Operator on OpenShift, due to inconsistent permissions between downstream and upstream CSVs #360PR acceptance criteria
rhdh-operator.csv.yamlfile accordinglyHow to test changes / Special notes to the reviewer
Diff should only be about the service account name:
$ diff -U 1 \ <(yq '.spec.install.spec.clusterPermissions' bundle/manifests/backstage-operator.clusterserviceversion.yaml) \ <(yq '.spec.install.spec.clusterPermissions' .rhdh/bundle/manifests/rhdh-operator.csv.yaml) --- /proc/self/fd/11 2024-05-14 16:28:32.538242718 +0200 +++ /proc/self/fd/12 2024-05-14 16:28:32.539242725 +0200 @@ -107,2 +107,2 @@ - create - serviceAccountName: backstage-controller-manager + serviceAccountName: rhdh-operatorWe can retry the repro steps depicted in #360 after a new downstream build is done (after this PR merged).