-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.2.x] Allow configuring the storage class name for PVCs used by both DB and app #392
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ds allowing to set storage class names for Application and Database PVCs This is a quick fix for 1.2, until https://issues.redhat.com/browse/RHIDP-2232 addresses CR customization in a more generic way
… select a storage class from a list populated from the cluster) As depicted in [1], this will display a list of storage classes from which the user can select a storage class. This can be useful to reduce errors when using the Operator. References - Operator SDK documentation [2] - OLM reference [3] [1] https://www.redhat.com/en/blog/openshift-4-2-declarative-dynamic-ui-for-your-operator [2] https://sdk.operatorframework.io/docs/building-operators/golang/references/markers/ [3] https://github.com/openshift/console/blob/master/frontend/packages/operator-lifecycle-manager/src/components/descriptors/reference/reference.md
0a54885
to
6c45a3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think new feature, especially related to API change can be a part of patch version (see https://semver.org/).
Instead, to make deployment configuration feature to be available sooner, I would propose to make a 0.3 (1.3) operator release, including #388, ASAP.
Sure, it can be seen as a feature semantically-speaking, but in my understanding, https://issues.redhat.com/browse/RHIDP-2705 has been marked as a blocker for 1.2.2, upon customer request. So it cannot wait for 1.3, I guess. #388 covers too many things right now; so to minimize the risks of introducing breaking changes to 1.2.2, it was concluded that a dedicated PR (addressing only the storage class request) would be created for 1.2.2, hence this PR. |
No, it does not, sorry :)
|
Customer confirmed this is not needed in 1.2.x /close |
@rm3l: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
This PR adds 2 new fields to the CRD:
spec.application.storageClassName
spec.database.storageClassName
They allow configuring the storage classes to be used by the PVCs created by the Operator, i.e., the ephemeral PVC created for the
dynamic-plugins-root
volume, as well as the PVC used by the local database StatefulSet.#388 intended to provide a more generic way to handle this (along with supporting customizing other properties like labels, annotations, resources, sidecar containers, ...), but it currently does not apply to the local database.
Given that https://issues.redhat.com/browse/RHIDP-2705 is a current a blocker for the upcoming 1.2.2 release, this PR is more focused, covering only the storage class use case with the current
v1alpha1
API version.#388 will need to be updated later for 1.3.
Preview in the OCP console
Which issue(s) does this PR fix or relate to
PR acceptance criteria
rhdh-operator.csv.yaml
file accordinglyHow to test changes / Special notes to the reviewer
(Tested on a ClusterBot cluster, but feel free to use any storage class on your particular cluster)
Then run
kubectl get pvc
and check the storage classes used by the PVCs, e.g.: