Add go dependencies (go mod tidy && go mod vendor) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerolimov
force-pushed
the
add-vendor
branch
from
67a4dd3
to
301e0c8
Compare
jerolimov
changed the title
jerolimov
force-pushed
the
add-vendor
branch
from
301e0c8
to
3d03314
Compare
|
I am not sure if using vendor folder for so small project is worth it, but I think that I do not know all aspects of this to be able to properly decide, so I will leave it probably up to others :). Ultimately personally I am not against it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up (and based on #11).
I created two so that you can hopefully merge #11 independently and then share if you are fine adding the vendor folders to this project.
To be honest, it just removes the dependency on downloading external sources when building the project, but it doesn't reduce the build time.
What do you think about including the dependency? I'm fine if you close this because it has less benefit than expected.