ci: install zlib1g-dev explicitly in Rust job#11
Merged
Conversation
Make the implicit system zlib dependency explicit so the build does not silently depend on ubuntu-latest's pre-installed packages. Without this, a future runner image change or a minimal container build would fail with a missing -lz / zlib.h error even though LIBZ_SYS_STATIC=0 is set. Follow-up to PR #10 review feedback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Makes the Rust CI job explicitly install the system zlib development headers, aligning CI with the project’s switch to linking against system zlib (LIBZ_SYS_STATIC=0) so builds don’t rely on implicit runner image contents.
Changes:
- Add a CI step to install
zlib1g-devin the Rust job.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apt-get install -y zlib1g-devstep to the Rust CI job so the system zlib dependency (introduced byLIBZ_SYS_STATIC=0in PR fix(build): use system zlib instead of missing vendored sources #10) is explicit rather than implicit.ubuntu-latestships zlib headers pre-installed; a runner image change or minimal container build would silently break with a missing-lz/zlib.herror.Test plan
🤖 Generated with Claude Code