Removed autocommand usage#26
Closed
Avasam wants to merge 1 commit into
Closed
Conversation
1 task
Avasam
force-pushed
the
remove-autocommand
branch
2 times, most recently
from
18c27ca to
4fb5de7
Compare
Avasam
force-pushed
the
remove-autocommand
branch
from
4fb5de7 to
14fd68a
Compare
Avasam
force-pushed
the
remove-autocommand
branch
from
14fd68a to
212f731
Compare
Avasam
force-pushed
the
remove-autocommand
branch
from
212f731 to
13a931a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One option to address pypa/setuptools#5045 is to simply remove
autocommandusage entirely. Imo using autocommand and/or Typer here felt overkill. The following error really isn't that obscure:Also relates to pypa/setuptools#5049
Alternative to, and closes #24 + closes #25