Skip to content

fix(3280): submitForm should reject on validation fail #3995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −0
Open

fix(3280): submitForm should reject on validation fail #3995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/formik/src/Formik.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,6 +797,9 @@ export function useFormik<Values extends FormikValues = FormikValues>({
// throw combinedErrors;
if (isInstanceOfError) {
throw combinedErrors;
} else {
// need to fulfill contract: submitForm will throw if validation fails
throw new Error();
}
}
return;
Expand Down
15 changes: 15 additions & 0 deletions packages/formik/test/Formik.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,21 @@ describe('<Formik>', () => {
);
});
});
it('submit should reject if validate returns error', async () => {
const onSubmit = jest.fn();
const validate = jest.fn().mockResolvedValue({ error: 'error' });
// expect(global.console.warn).not.toHaveBeenCalled();

const { getProps } = renderFormik({ onSubmit, validate });

await act(async () => {
await expect(getProps().submitForm()).rejects.toThrow();
});

await waitFor(() => {
expect(onSubmit).not.toBeCalled();
});
});
});

describe('with validationSchema (ASYNC)', () => {
Expand Down
Loading