Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable warnings #452

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Disable warnings #452

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a6926f
Move `result` up and return it
WSoptics Mar 20, 2025
e96358d
Remove harmful dtor definition
WSoptics Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions include/cxxopts.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1302,8 +1302,6 @@ template <>
class standard_value<bool> : public abstract_value<bool>
{
public:
~standard_value() override = default;

standard_value()
{
set_default_and_implicit();
Expand Down Expand Up @@ -2776,18 +2774,18 @@ Options::help_one_group(const std::string& g) const
{
using OptionHelp = std::vector<std::pair<String, String>>;

String result;

auto group = m_help.find(g);
if (group == m_help.end())
{
return "";
return result;
}

OptionHelp format;

std::size_t longest = 0;

String result;

if (!g.empty())
{
result += toLocalString(" " + g + " options:\n");
Expand Down
Loading