Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bukuserver] functional tests #670

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

LeXofLeviafan
Copy link
Collaborator

automates a part of these tests (by examining response HTML):

also:

  • changing the views to access runtime values of BUKUSERVER_PER_PAGE & BUKUSERVER_URL_RENDER_MODE instead of memorising initial ones
  • simplifying last_page() logic

@LeXofLeviafan LeXofLeviafan force-pushed the bukuserver-tests branch 2 times, most recently from e237e5d to 5e4fd9e Compare January 27, 2023 18:13
@jarun
Copy link
Owner

jarun commented Jan 28, 2023

@rachmadaniHaryono please review.

@LeXofLeviafan
Copy link
Collaborator Author

Note: did a rebase

@LeXofLeviafan
Copy link
Collaborator Author

…Come to think of it, the locale support doesn't work without installing flask-babelex; so we should either mention it in the readme, or add it to the server deps.

I think I prefer the latter as it appears that flask-admin is going to change the dependency to flask-babel on the next release (which isn't a drop-in update for us as it initialises locale-selector differently). Though it seems like flask-babelex will still be supported, it's still a deprecated package.

@jarun
Copy link
Owner

jarun commented Feb 8, 2023

@LeXofLeviafan @rachmadaniHaryono can this be merged?

@LeXofLeviafan
Copy link
Collaborator Author

Yes, as far as I'm concerned. Still waiting for feedback from the other guy tho.
(I've also got no responses on the locale support thing from my last comment…)

@LeXofLeviafan LeXofLeviafan force-pushed the bukuserver-tests branch 3 times, most recently from c68c225 to 7fee8bc Compare September 11, 2023 20:40
@jarun jarun merged commit 14fb6bd into jarun:master Sep 12, 2023
1 check passed
@jarun
Copy link
Owner

jarun commented Sep 12, 2023

Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
@LeXofLeviafan LeXofLeviafan deleted the bukuserver-tests branch August 24, 2024 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants