Add per user time zone support #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Guo
reviewed
Aug 14, 2019
|
|
||
| private | ||
| def set_time_zone | ||
| Time.zone = current_user.time_zone if current_user and current_user.time_zone.present? |
There was a problem hiding this comment.
Suggested change
| Time.zone = current_user.time_zone if current_user and current_user.time_zone.present? | |
| Time.zone = current_user.time_zone if current_user&.time_zone&.present? |
Eric-Guo
suggested changes
Aug 14, 2019
Xu-Zhiqing
added a commit
to Xu-Zhiqing/cybros_core
that referenced
this pull request
Aug 14, 2019
Xu-Zhiqing
force-pushed
the
user-time-zone
branch
from
03b4637 to
0b9f616
Compare
Xu-Zhiqing
added a commit
to Xu-Zhiqing/cybros_core
that referenced
this pull request
Aug 14, 2019
|
感谢你！最近稍微有一点忙，我会晚点时间处理 |
Xu-Zhiqing
force-pushed
the
user-time-zone
branch
from
a3bd0ad to
779c29e
Compare
Xu-Zhiqing
added a commit
to Xu-Zhiqing/cybros_core
that referenced
this pull request
Aug 14, 2019
# Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # Date: Wed Aug 14 17:45:34 2019 +0800 # # On branch user-time-zone # Your branch is up to date with 'origin/user-time-zone'. # # Changes to be committed: # modified: app/controllers/application_controller.rb # new file: db/migrate/20190809022738_add_user_time_zone.rb # new file: db/migrate/20190814094307_add_user_time_zone.rb # # Changes not staged for commit: # deleted: db/migrate/20190814094307_add_user_time_zone.rb # # Untracked files: # .generators # .idea/ # .rakeTasks #
Xu-Zhiqing
force-pushed
the
user-time-zone
branch
from
779c29e to
770b2a1
Compare
Xu-Zhiqing
added a commit
to Xu-Zhiqing/cybros_core
that referenced
this pull request
Aug 14, 2019
Xu-Zhiqing
force-pushed
the
user-time-zone
branch
from
770b2a1 to
a117106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.