-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reference tests for easycrypt extraction #863
base: main
Are you sure you want to change the base?
Conversation
@vbgl Do you know why the CI fails? I see that https://gitlab.com/jasmin-lang/jasmin/-/jobs/7317501176 fails because of Running |
- Do not clutter the compiler/ directory with temp files: the test results are now in deterministic locations, in a file hierarchy under compiler/tests/results - Tell easycrypt to use eclib from this repo.
Is it really needed to store so many expected test results? Shouldn’t a checksum be enough to detect regressions? |
That could be done indeed, but w'd loose:
It is debatable whether 1. is a good idea to have. For 2., I think that it's a significant annoyance. The long-term plan of @eponier is to move this to dune "cramtest" (and extend it to also check assembly output). We could also try to reduce the number of files by putting all the test results in a single file (tar-like, but in a human-readable format). Would that help to adress your concerns ? Is the issue more w.r.t. to the number of files, or with the amount of data in the repository ? |
I’m mostly concerned by the amount of data that is added there. |
(To quantify: it's about 6.8 MB of data.) I have no strong opinion (and I am not a maintainer), so I'm totally open to moving to hashes. We can always change the approach later if point 2. above ends up being too annoying. Should I move forward with a solution with hashes? |
Tests that the easycrypt extraction matches vested "golden" files, up to insignificant whitespace changes.