Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readme, updates and repairs #10

Merged
merged 5 commits into from
Sep 2, 2018
Merged

Conversation

Spectre5
Copy link
Contributor

@Spectre5 Spectre5 commented Sep 2, 2018

added readme
changed to all relative imports
fixed stephabegg
fixed installation via "pip install ."
fixed summitpost
correction to test_shared
updated app.py to include a convenient test function for localhost

@Spectre5 Spectre5 changed the title Added readme, changed to all relative imports, fixed stephabegg Add readme, updates and repairs Sep 2, 2018
@Spectre5 Spectre5 force-pushed the master branch 2 times, most recently from cb38dc3 to eacc52b Compare September 2, 2018 05:53
@Spectre5
Copy link
Contributor Author

Spectre5 commented Sep 2, 2018

Can also test with tox using:
tox
source .tox/py36/bin/activate
trfind 48.51152 -121.05789 "Forbidden Peak"

Copy link
Owner

@jason-curtis jason-curtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! only minor comments.

Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
trfind/find.py Outdated Show resolved Hide resolved
trfind/finders/stephabegg.py Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Show resolved Hide resolved
trfind/finders/summitpost.py Show resolved Hide resolved
@jason-curtis
Copy link
Owner

fixes #1

@Spectre5
Copy link
Contributor Author

Spectre5 commented Sep 2, 2018

I think I've addressed these points in the new commit

@jason-curtis jason-curtis merged commit 33ad959 into jason-curtis:master Sep 2, 2018
@jason-curtis jason-curtis mentioned this pull request Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants