Open
Conversation
To handle tables with many columns (previously some columns would get commented out and not display at all).
Added in new div with the new css class tableContainer to support tables with many columns (once the extra columns are uncommented).
All columns are now shown rather than just the first five. The files phreeze.backbone/styles/style.css and phreeze.backbone/templates/ListView.tpl.tpl have been modified to support displaying extra tables nicely.
Additional fix for supporting more than 5 columns.
Additional fix to show all columns
Removed unnecessary whitespace
Extra columns are no longer commented out.
Additional fix for supporting showing all columns cleanly.
Previously added </div> in the wrong place.
Adapted new css class .tableContainer ( for cleanly displaying all columns) for responsive layout.
Fixed typos.
Apparently Phreeze is a bit picky regarding indentations...
Left out adding <div class="tableContainer"> previously.
Owner
|
sorry i took so long to check this out, i have been seriously ill recently. this looks great though, I'm going to check it out and see about merging into the main branch. thanks so much for the contribution! |
Author
|
Hope you're better now! Good deal, we are happy to help! We mostly use the smarty template version, but the updates were made to the blade files too. |
Author
|
Any additional feedback on this? I vaguely remember you saying you wanted it to better follow Bootstrap standards, but I can't find that email anymore. I would really like to get this finished and approved :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates made to css and ListView templates allow for displaying all columns cleanly by default, rather than only showing up to the first five columns and commenting out the rest. For tables with few columns, they are no longer spread out over the whole width. Many columns now results in a horizontal overflow scrollbar.
Eventually I would like to make a setting in the build that would specify one column to remain fixed at left, so that when scrolling through the other columns you can still see which entry you are looking at. This would likely require the static column to be displayed in a separate table structurally, while looking like one table visually.
