Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when typing "s" and "d" + any character #52

Closed
wants to merge 1 commit into from
Closed

Fix bug when typing "s" and "d" + any character #52

wants to merge 1 commit into from

Conversation

olliecheng
Copy link

Addresses #40. Recreated because somehow I managed to delete denosawr:master, which closed the PR (?!).

Before this, typing "s" or "d" along with any other character in quick succession (< MAX_TIME_BETWEEN_SIMULTANEOUS_KEY_PRESSES) would end up inserting that character before the "s" or "d". This commit fixes that.
@jasonrudolph
Copy link
Owner

👋 Hi @denosawr: Sorry I haven't had time to review this pull request. In the meantime, if anyone else is running into the issue you're seeing in #40, hopefully they'll apply this patch to their local clone of the repository and that will resolve the problem for them.

@jasonrudolph
Copy link
Owner

Addresses #40.

Now that #61 is merged, (S)uper(D)uper mode is implemented solely via Karabiner-Elements, which means that #40 should be resolved, so I'm gonna close this pull request. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants