-
Notifications
You must be signed in to change notification settings - Fork 123
Dwell time calculation while a video in iFrame is getting played #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
When a user clicks on any iFrame Timer will stop as window gets blur. Timer will start again only when it gets focus. It will get focus by clicking on the page. So in addition to that now timer will also start when user moves mouse on screen.
Hi! Thanks for the pull request. I do not understand your description of the solution. I tried your code in a test page with an embedded youtube video (iFrame), but the timer in the parent page still stops when you click on the youtube video, even as you move the mouse. |
Hi, Thanks for your response. |
Before the fix: When the user clicks inside the iFrame, the timer stops immediately. When user goes back to the main page, the timer doesn't resume itself. Check this video for better understanding : https://youtu.be/mZq3K8IIGRM After the fix by @HarithaKintali After updating the code, this issue is fixed as shown in this video https://youtu.be/DQi05-Nw8Lc
|
@jasonzissman Did you get a chance to look at the pull request? |
This fixed a problem I've been having with embedded Vimeo movies. However, I've been hit by a side effect. Apparently there are a lot of people out there still using IE and this fix broke all textareas and text inputs in IE. I can click in a textarea and start writing, but if I move my mouse pointer even the slightest (which people tend to do), the textarea looses focus. Any fix for that? |
Has anybody found a fix for the last described side effect ? Thx ! |
I have pushed a new solution for this issue and I would love to have your feedback on it: #77 |
When a user clicks on any iFrame Timer will stop as window gets blur. Timer will start again only when it gets focus. It will get focus by clicking on the page. So in addition to that now timer will also start when user moves mouse on screen.