Skip to content

Commit

Permalink
JASP QML Controls base objects should be registered automatically
Browse files Browse the repository at this point in the history
Use QML_ELEMENT
Remove import version in other QML files
  • Loading branch information
boutinb committed Jan 14, 2025
1 parent e32ad10 commit 769d232
Show file tree
Hide file tree
Showing 103 changed files with 172 additions and 258 deletions.
2 changes: 1 addition & 1 deletion Desktop/components/JASP/Widgets/ComputeColumnWindow.qml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ FocusScope
{
id: computeColumnEdit

RSyntaxHighlighterQuick
JaspControls.RSyntaxHighlighterQuick
{
textDocument: computeColumnEdit.textDocument
}
Expand Down
4 changes: 2 additions & 2 deletions Desktop/components/JASP/Widgets/CreateComputeColumnDialog.qml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import QtQuick 2.9
import QtQuick.Controls 2.2
import QtQuick
import QtQuick.Controls
import JASP.Controls as JaspControls


Expand Down
6 changes: 3 additions & 3 deletions Desktop/components/JASP/Widgets/DataPanel.qml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import QtQuick.Controls 6.0
import QtQuick.Layouts 1.0
import QtQuick 2.15
import QtQuick.Controls
import QtQuick.Layouts
import QtQuick


Rectangle
Expand Down
4 changes: 2 additions & 2 deletions Desktop/components/JASP/Widgets/FileMenu/CurrentFile.qml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import QtQuick 2.9
import QtQuick.Controls 2.2
import QtQuick
import QtQuick.Controls


Item
Expand Down
6 changes: 3 additions & 3 deletions Desktop/components/JASP/Widgets/FileMenu/DataLibrary.qml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import QtQuick 2.9
import QtQuick.Controls 2.2
import QtQuick.Layouts 1.3
import QtQuick
import QtQuick.Controls
import QtQuick.Layouts


Item
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import QtQuick 2.0
import QtQuick.Layouts 1.3
import QtQuick.Controls 2.2
import JASP.Theme 1.0
import QtQuick
import QtQuick.Layouts
import QtQuick.Controls
import JASP.Theme

ListView
{
Expand Down
4 changes: 2 additions & 2 deletions Desktop/components/JASP/Widgets/FileMenu/PrefsTextInput.qml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import QtQuick 2.15
import QtQuick.Controls 2.15
import QtQuick
import QtQuick.Controls

Rectangle
{
Expand Down
6 changes: 3 additions & 3 deletions Desktop/components/JASP/Widgets/FileMenu/RecentFiles.qml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import QtQuick 2.9
import QtQuick.Controls 2.2
import QtQuick.Layouts 1.3
import QtQuick
import QtQuick.Controls
import QtQuick.Layouts


Item
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import QtQuick 2.0
import QtQuick

DragGeneric
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import QtQuick 2.9
import QtQuick.Controls 2.2
import QtQuick
import QtQuick.Controls


MouseArea
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import QtQuick 2.9
import QtQuick.Controls 2.2
import QtQuick
import QtQuick.Controls



Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import QtQuick 2.9
import QtQuick.Controls 2.2
import QtQuick
import QtQuick.Controls

DropArea
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import QtQuick 2.0
import QtQuick


ListView
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import QtQuick 2.9
import QtQuick


Item
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import QtQuick 2.0
import QtQuick

DragGeneric {
shownChild: showMe
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import QtQuick 2.0
import QtQuick

Item
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import QtQuick 2.0
import QtQuick

DragGeneric {
property real value: 0
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import QtQuick 2.9
import QtQuick


Item
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import QtQuick 2.0
import QtQuick

DragGeneric {
shownChild: showMe
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import QtQuick 2.0
import QtQuick

Item
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import QtQuick 2.0
import QtQuick

Item
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import QtQuick 2.9
import QtQuick


Item
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import QtQuick 2.0
import QtQuick

DragGeneric {
shownChild: showMe
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import QtQuick 2.0
import QtQuick

Item
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import QtQuick 2.0
import QtQuick

DragGeneric {
property string text: "?"
Expand Down
4 changes: 2 additions & 2 deletions Desktop/components/JASP/Widgets/FilterWindow.qml
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ FocusScope

TextArea
{
RSyntaxHighlighterQuick
JaspControls.RSyntaxHighlighterQuick
{
textDocument: filterGeneratedEdit.textDocument
}
Expand Down Expand Up @@ -351,7 +351,7 @@ FocusScope
TextArea
{

RSyntaxHighlighterQuick
JaspControls.RSyntaxHighlighterQuick
{
textDocument: filterEdit.textDocument
}
Expand Down
2 changes: 1 addition & 1 deletion Desktop/components/JASP/Widgets/ImageInverter.qml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import QtQuick 2.15
import QtQuick

///Setting src to an Image will put this image inverter there and enable/disable it based on a dark theme is enabled. This is especially useful for getting the negative of a plot
ShaderEffect
Expand Down
4 changes: 2 additions & 2 deletions Desktop/components/JASP/Widgets/JASPMouseAreaToolTipped.qml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import QtQuick 2.9
import QtQuick.Controls 2.2
import QtQuick
import QtQuick.Controls

MouseArea
{
Expand Down
6 changes: 3 additions & 3 deletions Desktop/components/JASP/Widgets/JASPSplitHandle.qml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import QtQuick 2.11
import JASP.Widgets 1.0
import QtQuick.Controls 6.0
import QtQuick
import JASP.Widgets
import QtQuick.Controls

//Only works vertically right now...

Expand Down
2 changes: 1 addition & 1 deletion Desktop/components/JASP/Widgets/LoadingIndicator.qml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import QtQuick 2.12
import QtQuick

Item
{
Expand Down
6 changes: 3 additions & 3 deletions Desktop/components/JASP/Widgets/MainWindow.qml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
// <http://www.gnu.org/licenses/>.
//

import QtQuick 2.11
import QtQuick.Window 2.11
import QtQuick
import QtQuick.Window
import JASP
import QtQuick.Controls 2.12
import QtQuick.Controls

Window
{
Expand Down
4 changes: 2 additions & 2 deletions Desktop/components/JASP/Widgets/ProgressBarHolder.qml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import QtQuick 2.11
import QtQuick.Controls 2.4
import QtQuick
import QtQuick.Controls


Item
Expand Down
4 changes: 2 additions & 2 deletions Desktop/components/JASP/Widgets/Ribbon/MenuArrowButton.qml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
// <http://www.gnu.org/licenses/>.
//

import QtQuick 2.11
import QtQuick.Controls 2.4
import QtQuick
import QtQuick.Controls


Rectangle
Expand Down
2 changes: 1 addition & 1 deletion Desktop/components/JASP/Widgets/Ribbon/RibbonBar.qml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// <http://www.gnu.org/licenses/>.
//

import QtQuick 2.11
import QtQuick
import JASP


Expand Down
8 changes: 4 additions & 4 deletions Desktop/components/JASP/Widgets/Ribbon/RibbonButton.qml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
// <http://www.gnu.org/licenses/>.
//

import QtQuick 2.11
import QtQuick.Controls 2.4
import JASP 1.0
import JASP.Widgets 1.0
import QtQuick
import QtQuick.Controls
import JASP
import JASP.Widgets

Item
{
Expand Down
4 changes: 2 additions & 2 deletions Desktop/components/JASP/Widgets/Ribbon/Ribbons.qml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
// <http://www.gnu.org/licenses/>.
//

import QtQuick 2.15
import QtQuick.Controls 2.15
import QtQuick
import QtQuick.Controls
import JASP

Item
Expand Down
4 changes: 2 additions & 2 deletions Desktop/components/JASP/Widgets/SaveDiscardCancelDialog.qml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import QtQuick 2.12
import JASP 1.0
import QtQuick
import JASP

QtObject
{
Expand Down
2 changes: 1 addition & 1 deletion Desktop/components/JASP/Widgets/SpinBox.qml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ Item
TextField
{
id: valueField
validator: JASPDoubleValidator { id: doubleValidator; bottom: root.min; top: root.max ; decimals: root.decimals }
validator: JaspControls.JASPDoubleValidator { id: doubleValidator; bottom: root.min; top: root.max ; decimals: root.decimals }
anchors
{
left: minus.right
Expand Down
6 changes: 3 additions & 3 deletions Desktop/components/JASP/Widgets/UIScaleNotifier.qml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import QtQuick 2.11
import QtQuick.Controls 2.4
import JASP.Widgets 1.0
import QtQuick
import QtQuick.Controls
import JASP.Widgets

Item
{
Expand Down
43 changes: 0 additions & 43 deletions Desktop/mainwindow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,27 +39,6 @@

#include "mainwindow.h"

#include "analysisform.h"
#include "controls/jaspcontrol.h"
#include "controls/checkboxbase.h"
#include "controls/comboboxbase.h"
#include "controls/textinputbase.h"
#include "controls/componentslistbase.h"
#include "controls/rsyntaxhighlighter.h"
#include "controls/factorsformbase.h"
#include "controls/inputlistbase.h"
#include "controls/textareabase.h"
#include "controls/sliderbase.h"
#include "controls/expanderbuttonbase.h"
#include "controls/variableslistbase.h"
#include "controls/variablesformbase.h"
#include "controls/factorlevellistbase.h"
#include "controls/tableviewbase.h"
#include "controls/radiobuttonbase.h"
#include "controls/radiobuttonsgroupbase.h"
#include "controls/jaspdoublevalidator.h"
#include "controls/groupboxbase.h"

#include "gui/jaspversionchecker.h"
#include "gui/preferencesmodel.h"
#include "ALTNavigation/altnavigation.h"
Expand All @@ -69,7 +48,6 @@
#include "modules/activemodules.h"
#include "modules/dynamicmodules.h"
#include "modules/menumodel.h"
#include "modules/description/entrybase.h"

#include "qquick/datasetview.h"
#include "qquick/rcommander.h"
Expand Down Expand Up @@ -166,30 +144,9 @@ MainWindow::MainWindow(QApplication * application) : QObject(application), _appl

qmlRegisterType<DataSetView> ("JASP", 1, 0, "DataSetView" );
qmlRegisterType<JaspTheme> ("JASP", 1, 0, "JaspTheme" );
qmlRegisterType<AnalysisForm> ("JASP", 1, 0, "AnalysisForm" );
qmlRegisterType<RCommander> ("JASP", 1, 0, "RCommander" );
qmlRegisterType<JASPControl> ("JASP", 1, 0, "JASPControl" );
qmlRegisterType<GroupBoxBase> ("JASP", 1, 0, "GroupBoxBase" );
qmlRegisterType<ExpanderButtonBase> ("JASP", 1, 0, "ExpanderButtonBase" );
qmlRegisterType<CheckBoxBase> ("JASP", 1, 0, "CheckBoxBase" );
qmlRegisterType<SliderBase> ("JASP", 1, 0, "SliderBase" );
qmlRegisterType<TextInputBase> ("JASP", 1, 0, "TextInputBase" );
qmlRegisterType<TextAreaBase> ("JASP", 1, 0, "TextAreaBase" );
qmlRegisterType<ComboBoxBase> ("JASP", 1, 0, "ComboBoxBase" );
qmlRegisterType<RadioButtonBase> ("JASP", 1, 0, "RadioButtonBase" );
qmlRegisterType<RadioButtonsGroupBase> ("JASP", 1, 0, "RadioButtonsGroupBase" );
qmlRegisterType<RSyntaxHighlighterQuick> ("JASP", 1, 0, "RSyntaxHighlighterQuick" );
qmlRegisterType<ComponentsListBase> ("JASP", 1, 0, "ComponentsListBase" );
qmlRegisterType<FactorsFormBase> ("JASP", 1, 0, "FactorsFormBase" );
qmlRegisterType<InputListBase> ("JASP", 1, 0, "InputListBase" );
qmlRegisterType<FactorLevelListBase> ("JASP", 1, 0, "FactorLevelListBase" );
qmlRegisterType<VariablesListBase> ("JASP", 1, 0, "VariablesListBase" );
qmlRegisterType<VariablesFormBase> ("JASP", 1, 0, "VariablesFormBase" );
qmlRegisterType<TableViewBase> ("JASP", 1, 0, "TableViewBase" );
qmlRegisterType<JASPDoubleValidator> ("JASP", 1, 0, "JASPDoubleValidator" );
qmlRegisterType<ResultsJsInterface> ("JASP", 1, 0, "ResultsJsInterface" );
qmlRegisterType<ColumnModel> ("JASP", 1, 0, "ColumnModel" );
qmlRegisterType<FormulaBase> ("JASP", 1, 0, "Formula" );
qmlRegisterUncreatableType<PlotEditor::AxisModel> ("JASP.PlotEditor", 1, 0, "AxisModel", "Can't make it");
qmlRegisterUncreatableType<PlotEditor::PlotEditorModel> ("JASP.PlotEditor", 1, 0, "PlotEditorModel", "Can't make it");

Expand Down
Loading

0 comments on commit 769d232

Please sign in to comment.