Skip to content

Commit

Permalink
Add types in Formula
Browse files Browse the repository at this point in the history
More

Update wrapper in some modules

update submodules
  • Loading branch information
boutinb authored and JorisGoosen committed Nov 5, 2024
1 parent f86cf17 commit e1d6f31
Show file tree
Hide file tree
Showing 61 changed files with 359 additions and 418 deletions.
2 changes: 1 addition & 1 deletion Engine/jaspBase
Submodule jaspBase updated 1 files
+10 −7 R/formula.R
2 changes: 1 addition & 1 deletion Engine/jaspGraphs
2 changes: 1 addition & 1 deletion Modules/jaspAcceptanceSampling
Submodule jaspAcceptanceSampling updated 1 files
+23 −22 renv.lock
2 changes: 1 addition & 1 deletion Modules/jaspAudit
Submodule jaspAudit updated 1 files
+20 −19 renv.lock
2 changes: 1 addition & 1 deletion Modules/jaspBsts
Submodule jaspBsts updated 1 files
+20 −19 renv.lock
2 changes: 1 addition & 1 deletion Modules/jaspCircular
Submodule jaspCircular updated 1 files
+22 −21 renv.lock
2 changes: 1 addition & 1 deletion Modules/jaspCochrane
Submodule jaspCochrane updated 1 files
+29 −28 renv.lock
2 changes: 1 addition & 1 deletion Modules/jaspDistributions
Submodule jaspDistributions updated 1 files
+23 −22 renv.lock
2 changes: 1 addition & 1 deletion Modules/jaspEquivalenceTTests
Submodule jaspEquivalenceTTests updated 1 files
+25 −24 renv.lock
2 changes: 1 addition & 1 deletion Modules/jaspJags
Submodule jaspJags updated 1 files
+20 −19 renv.lock
2 changes: 1 addition & 1 deletion Modules/jaspLearnBayes
2 changes: 1 addition & 1 deletion Modules/jaspLearnStats
Submodule jaspLearnStats updated 1 files
+29 −28 renv.lock
2 changes: 1 addition & 1 deletion Modules/jaspMachineLearning
Submodule jaspMachineLearning updated 2 files
+3 −3 po/R-de.po
+22 −21 renv.lock
2 changes: 1 addition & 1 deletion Modules/jaspMetaAnalysis
Submodule jaspMetaAnalysis updated 2 files
+4 −4 po/R-de.po
+24 −23 renv.lock
2 changes: 1 addition & 1 deletion Modules/jaspMixedModels
2 changes: 1 addition & 1 deletion Modules/jaspNetwork
Submodule jaspNetwork updated 1 files
+25 −24 renv.lock
2 changes: 1 addition & 1 deletion Modules/jaspPower
Submodule jaspPower updated 1 files
+20 −19 renv.lock
2 changes: 1 addition & 1 deletion Modules/jaspPredictiveAnalytics
2 changes: 1 addition & 1 deletion Modules/jaspProcess
2 changes: 1 addition & 1 deletion Modules/jaspProphet
Submodule jaspProphet updated 1 files
+20 −19 renv.lock
2 changes: 1 addition & 1 deletion Modules/jaspQualityControl
Submodule jaspQualityControl updated 1 files
+28 −27 renv.lock
2 changes: 1 addition & 1 deletion Modules/jaspReliability
Submodule jaspReliability updated 1 files
+26 −35 renv.lock
2 changes: 1 addition & 1 deletion Modules/jaspRobustTTests
2 changes: 1 addition & 1 deletion Modules/jaspSem
Submodule jaspSem updated 1 files
+24 −23 renv.lock
2 changes: 1 addition & 1 deletion Modules/jaspSummaryStatistics
2 changes: 1 addition & 1 deletion Modules/jaspSurvival
Submodule jaspSurvival updated 1 files
+273 −738 renv.lock
2 changes: 1 addition & 1 deletion Modules/jaspVisualModeling
Submodule jaspVisualModeling updated 1 files
+28 −27 renv.lock
3 changes: 3 additions & 0 deletions QMLComponents/analysisform.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,9 @@ QString AnalysisForm::msgsListToString(const QStringList & list) const
if(list.length() == 0)
return "";

if (list.size() == 1)
return list[0];

QString text;
for (const QString & msg : list)
if(msg.size())
Expand Down
2 changes: 1 addition & 1 deletion QMLComponents/boundcontrols/boundcontrolbase.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ void BoundControlBase::_readTableValue(const Json::Value &value, const std::stri
}
}

Json::Value BoundControlBase::_getTableValueOption(const Terms& terms, const ListModel::RowControlsValues& componentValuesMap, const std::string& key, bool hasInteraction, bool keyHasVariables)
Json::Value BoundControlBase::_getTableValueOption(const Terms& terms, const ListModel::RowControlsValues& componentValuesMap, const std::string& key, bool hasInteraction, bool keyHasVariables) const
{
Json::Value result(Json::arrayValue);

Expand Down
2 changes: 1 addition & 1 deletion QMLComponents/boundcontrols/boundcontrolbase.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class BoundControlBase : public BoundControl
std::string getName() const;
void handleComputedColumn(const Json::Value& value);

Json::Value _getTableValueOption(const Terms& terms, const ListModel::RowControlsValues& componentValuesMap, const std::string& key, bool hasInteraction, bool keyHasVariables);
Json::Value _getTableValueOption(const Terms& terms, const ListModel::RowControlsValues& componentValuesMap, const std::string& key, bool hasInteraction, bool keyHasVariables) const;
void _setTableValue(const Terms& terms, const ListModel::RowControlsValues& componentValuesMap, const std::string& key, bool hasInteraction, bool keyHasVariables = false);

void _readTableValue(const Json::Value& value, const std::string& key, bool hasMultipleTerms, Terms& terms, ListModel::RowControlsValues& allControlValues);
Expand Down
2 changes: 1 addition & 1 deletion QMLComponents/boundcontrols/boundcontrollayers.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ bool BoundControlLayers::isJsonValid(const Json::Value &optionValue) const
{
const Json::Value& nameOption = value["name"];
const Json::Value& variablesOption = value["variables"];
valid = nameOption.type() == Json::stringValue && variablesOption.type() == Json::arrayValue;
valid = nameOption.type() == Json::stringValue && (variablesOption.type() == Json::arrayValue || variablesOption.type() == Json::stringValue);

if (!valid)
break;
Expand Down
Loading

0 comments on commit e1d6f31

Please sign in to comment.