Fix some sync bugs #5321
Merged
Fix some sync bugs #5321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jasp-stats/jasp-test-release#2371 Fixes also: . Open a csv file with JASP. . Make a change in JASP: Sync icon turns off . Undo: Sync icon stays off . Click on Sync icon: it reloads the data: Sync icon turns on . Change data in JASP: the Sync icon stays on: this is wrong. This is fixes by this PR. .
JorisGoosen
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/jasp-stats/jasp-test-release/issues/2371
There was 2 bugs in this issue:
Fixes also the following bug: