EmptyValues updates should work (also for files from 0.18.1) #5347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure changes are updated in database Also prepare the upgradeDB function in databaseInterface for future changes
JorisGoosen
changed the title
JorisGoosen
changed the title
|
Could you provide a reproduction path of what this PR solves? |
For a bonus, I think it crashes if you try to then set empty values on the column but I might've misremembered. |
|
It also makes sure the database is upgraded at the right moment |
3 tasks
When loading a 0.18.1 JASP file, the workspace default values are empty. They should be set to the preferences empty values as default (since there is no workspace empty values in 0.18.1). In DataSet::setEmptyValuesJson, there was already an handling to overcome this issue, but as DataSet has no access to the PreferencesModel object, it was depending of setting the _defaultEmptyvalues property just after the DataSet was created. But as DataSet might be deleted and created several times, the _defaultEmptyvalues is not always set. So just make it a static property, so that it just has to be set once.
|
There was still a problem: the workspace empty values are empty when a 0.18.1 JASP file is loaded. I have just added a commit to solve this. |
|
So approved and it can be merged? |
boutinb
approved these changes
Dec 14, 2023
JorisGoosen
added a commit
that referenced
this pull request
Jan 2, 2024
* EmptyValues updates should also work for files from 0.18.1 Make sure changes are updated in database Also prepare the upgradeDB function in databaseInterface for future changes * Workspace emptyvalues must have default values When loading a 0.18.1 JASP file, the workspace default values are empty. They should be set to the preferences empty values as default (since there is no workspace empty values in 0.18.1). In DataSet::setEmptyValuesJson, there was already an handling to overcome this issue, but as DataSet has no access to the PreferencesModel object, it was depending of setting the _defaultEmptyvalues property just after the DataSet was created. But as DataSet might be deleted and created several times, the _defaultEmptyvalues is not always set. So just make it a static property, so that it just has to be set once. --------- Co-authored-by: boutinb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure changes are updated in database
Also prepare the upgradeDB function in databaseInterface for future changes
I stopped working on the refactor of EmptyValues, thatll be for post-0.18.2
This should at least make empty values per column etc work for files from 0.18.1 (and perhaps more)