Fix syntax check on columns flux #5350
Conversation
JorisGoosen
changed the title
… time JASP crashes when closing the workspace if a TextArea was open in an Analysis form.
| connect(this, SIGNAL(applyRequest()), this, SLOT(checkSyntaxHandler())); | ||
| //If "rowCount" changes on VariableInfo it means a column has been added or removed, this means the model should be reencoded and checked | ||
| //Fixes https://github.com/jasp-stats/jasp-issues/issues/2462 | ||
| connect(VariableInfo::info(), &VariableInfo::rowCountChanged, this, &TextAreaBase::checkSyntaxHandler); |
There was a problem hiding this comment.
Not really beautiful, but I don't see how to do that in another way.
There was a problem hiding this comment.
well we couldve added more signals and all that but this should work fine
| @@ -48,6 +48,7 @@ void RowControls::init(int row, const Term& key, bool isNew) | |||
| context->setContextProperty("rowValue", key.asQString()); | |||
|
|
|||
| _rowObject = qobject_cast<QQuickItem*>(_rowComponent->create(context)); | |||
| _rowObject->setParent(_parentModel); | |||
There was a problem hiding this comment.
This is needed: the rowObject was not deleted.... and so all rowComponents.
This can make JASP crashing because these components can be connected to VariableInfo signals even if the analysis does not exist.
But I suggest we do that later, I could do it together with the refactor of empty values that im planning for after the release. |
* Make sure to update ColumnEncoder at right times * make sure textarea runs checkSyntax whenever amount of columns changes * RowComponent should get the right parent to be destroyed at the right time JASP crashes when closing the workspace if a TextArea was open in an Analysis form. --------- Co-authored-by: boutinb <[email protected]>
Fixes jasp-stats/jasp-issues#2462