Fix comma sensitivity #5368
Merged
Fix comma sensitivity #5368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change separator to ';' and add to entries with a comma as decimal to detect problems like jasp-stats/jasp-issues#2499
Partial fix for jasp-stats/jasp-issues#2499
|
@boutinb this is ready for review |
boutinb
approved these changes
Jan 4, 2024
|
This PR should be merge to stable, no? |
|
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it so that during non-readstat imports any commas in a single value are interpreted as a decimal.
This PR will also fix the fact that data-library files opened from recent-files do not know they are from the data library.