Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes audit sampling filtereddataentry getting stuck #5370

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Fixes audit sampling filtereddataentry getting stuck #5370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Desktop/data/computedcolumnsmodel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,8 @@ void ComputedColumnsModel::checkForDependentAnalyses(const std::string & columnN
stringset usedCols = analysis->usedVariables(),
createdCols = analysis->createdVariables();

//Dont create an infinite loop please
if(usedCols.count(columnName) && !createdCols.count(columnName))
//Dont create an infinite loop please, but do this only for non-computed columns created by an analysis (aka distributions, because otherwise it breaks things like planning from audit)
if(usedCols.count(columnName) && (!createdCols.count(columnName) || !DataSetPackage::pkg()->isColumnAnalysisNotComputed(columnName)))
{
bool allColsValidated = true;

Expand Down
Loading