A computed column is not always computed when opening a JASP file #5380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make a JASP file with several analyses. Add a computed column by using another column. Save it, close it, and open it again: the computed column is not computed due to an engine crash. This crash is due to the fact that when trying to compute the computed column, the ColumnEncoder in the Engine was not yet initilalized with the names of the columns.
|
Ok @boutinb ive made the code a bit less duplicated and feisty, it should still work the same way though. If you agree with my changes we can merge it |
JorisGoosen
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a JASP file with several analyses.
Add a computed column by using another column.
Save it, close it, and open it again: the computed column is not computed due to an engine crash.
This crash is due to the fact that when trying to compute the computed column, the ColumnEncoder in the Engine was not yet initilalized with the names of the columns.