apply all upgrades and also try it on meta #5396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously a bug could occur in a specific situation: say a module QC has an upgrade from 0.18.1 to 0.18.2 ijn 0.18.2. This works! now some time later in version 0.19 an upgrade is added going from 0.18.2 to 0.19. Because of flawed logic this dropped the 0.18.1->2 upgrade... Besides that Ive added logging of options between each upgrade step, this should help module developers out and bugreports as well Then there is an attempt added to also update the `.meta` in options, this should work for renames etc, and I dont think it will break anything else?
JTPetter
approved these changes
Jan 22, 2024
boutinb
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously a bug could occur in a specific situation: say a module QC has an upgrade from 0.18.1 to 0.18.2 ijn 0.18.2. This works! now some time later in version 0.19 an upgrade is added going from 0.18.2 to 0.19. Because of flawed logic this dropped the 0.18.1->2 upgrade...
Besides that Ive added logging of options between each upgrade step, this should help module developers out and bugreports as well
Then there is an attempt added to also update the
.metain options, this should work for renames etc, and I dont think it will break anything else?