Renv Lockfiles + Flatpak Dev modules #5556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When this is merged we can remove module install code from jaspBase. |
|
Nice! I can build and run it perfectly well on windows on release. |
|
Alright, the good branch does work, however I still cant install dev modules. |
shun2wang
reviewed
Jun 11, 2024
| @@ -0,0 +1,23 @@ | |||
| { | |||
| "R": { | |||
| "Version": "4.3.3", | |||
There was a problem hiding this comment.
Why we lock all R version to 4.3.3?
There was a problem hiding this comment.
This is ignored. We will have runners to automatically update these lockfiles in the future
Any logs? |
RensDofferhoff
force-pushed
the
lockfiletesting
branch
3 times, most recently
from
ab24910
to
a6131f3
Compare
RensDofferhoff
force-pushed
the
lockfiletesting
branch
2 times, most recently
from
f867386
to
b8a668a
Compare
RensDofferhoff
force-pushed
the
lockfiletesting
branch
2 times, most recently
from
e1abb02
to
c173649
Compare
RensDofferhoff
force-pushed
the
lockfiletesting
branch
3 times, most recently
from
8a781bf
to
b217dc2
Compare
very basic functionality works start on making hashes work seems more or less functional now started rewriting cmake, stuff compiles but crashes at runtime everything seems functional on Linux windows fixes, stuff compiles but weird runtime error building on windows works from a clean build, but more testing is needed more tweaks, update to renv 1.0.2 updates for fallback without lockfile start unifying stuff across OSes autogenerated lockfiles seem to be work okay but need more testing reorganize file + pkgdepends fallback bump jaspModuleInstaller spaces -> tabs bump jaspModuleInstaller spaces -> tabs moved getModuleDependencies to jaspModuleInstaller call setupRenv in setup_renv_rcpp_rinside_jaspModuleInstaller.R.in remove custom Matrix installation make configuration work on macos compilation still fails though... do follow symlinks otherwise it patches nothing move searching for fortran outside of the "does framework not exist if()f" jaspModuleInstaller and fixing of r pkgs needs jaspEngine so change the order in which things are installed add R_LIBS for windows and macos make windows start
now it builds again on macos arm without R installed
RensDofferhoff
force-pushed
the
lockfiletesting
branch
from
b217dc2
to
78d4157
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to renv lockfiles installed using jaspModuleInstaller.
Renv lockfiles in each jasp Module contain all dependencies of the module.
jaspModuleInstaller will add/alter records to this lockfile to produce _processedLockFile.lock.
renv restore is called on this lockfile.
If MODULE_INSTALL_MODE is localizeAll every jaspModule source in the lockfile will be altered to those in the install folder. This mode is used in compilation of jasp.
If it is localizeModuleOnly (as for dev module installation) only a record to source of module to be installed is added.
Flatpak installation now uses an renv cellar. Cellars are generated using the same mechanisms as normal installation. This way no special gathering script is required.
See https://static.jasp-stats.org/Nightlies/ for the latest lockfiletesting nightlies
Todo:
Known Issues:
jaspProcess is not installed correctly on Mac because blavaan compilation fails. I have no clue why but if we just use the CRAN binaries its all fine. I have a PR for this: jasp-stats/jaspProcess#102
Maybe @vandenman has any clue why this is going on. Seems to fail on rstantools call.