fix renv install on mac #5697
Merged
fix renv install on mac #5697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boutinb
approved these changes
Oct 14, 2024
vandenman
reviewed
Oct 15, 2024
| WORKING_DIRECTORY ${R_HOME_PATH} | ||
| COMMAND | ||
| ${CMAKE_COMMAND} -D | ||
| NAME_TOOL_PREFIX_PATCHER=${PROJECT_SOURCE_DIR}/Tools/macOS/install_name_prefix_tool.sh |
There was a problem hiding this comment.
@RensDofferhoff just for my understanding, which .so file needed to get patched here? Something from Rcpp of RInside?
There was a problem hiding this comment.
See the renv changelog: https://rstudio.github.io/renv/news/index.html
There now exist a renv.so in libs/ when it is build
This needs to be patched and signed so it may be loaded later on.
before this version 1.0.11 it didn't exist.
RensDofferhoff
added a commit
to RensDofferhoff/jasp-desktop
that referenced
this pull request
Oct 15, 2024
Co-authored-by: Rens <example>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.