Label and levels improvement #5700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if there are no 'Label's yet and the user changes the value in the levelseditor to a string some labels will need to be made. There are some clearly marked functions for this, however, it would always return the last double replaced. This is usually what is wanted because the other values need not be replaced but when everything is replaced for convenience the right one should be taken (the one the user edited...) Not the last one.
boutinb
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a bunch of changes @boutinb made in #5630
This also aims to solve the same problems, but I didnt see the need for quite a few changes that were made in that PR.
To keep things trackable I opted to start a bit fresh to avoid messing up the logic.
Co-authored-by: "Bruno Boutin" [email protected]