NewDevMod system (#5707) #5711
Merged
NewDevMod system (#5707) #5711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boutinb
force-pushed
the
newDevModSystem
branch
from
f6752ca to
a242aa5
Compare
JorisGoosen
force-pushed
the
newDevModSystem
branch
3 times, most recently
from
1e1944e to
efc8be9
Compare
JorisGoosen
reviewed
Oct 24, 2024
|
|
||
| std::string _system(std::string cmd) | ||
| { | ||
| const char *root, *relativePath; | ||
|
|
||
| if (!rbridge_requestTempFileName("log", &root, &relativePath)) |
There was a problem hiding this comment.
Not that im saying you cant just use temp_directory_path, but im curious as to why.
JorisGoosen
reviewed
Oct 24, 2024
JorisGoosen
reviewed
Oct 24, 2024
|
The code looks good overall btw, ill test it some after the release and if we arent sinking into hotfixhell for the next month we'll probably merge it before @RensDofferhoff is back from vacation. |
JorisGoosen
force-pushed
the
newDevModSystem
branch
from
2b66256 to
31e0cfa
Compare
* New Devmod System (#5701) * New dev module system (#5690) * initial functional draft * add ugly name thing for now * fix some issues loading sepertly compiled modules on mac * fix more mac specific issues * add shortcuts for manual reload of devmodules , add safety copy to mac --------- Co-authored-by: Rens <example> * Update otoolstuff.cpp * fix windows compile
JorisGoosen
force-pushed
the
newDevModSystem
branch
from
6bc00b2 to
8d9c0d4
Compare
Like the name and libpath of a direct libpath dev module
JorisGoosen
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Ive made some changes to the GUI and some interactions, making things a bit prettier and userfriendly.
As far as Im concerned this is now all A-OK and can be merged.
Would be nice to have this in the release actually.
Maybe @boutinb wants to have a go though? (At reviewing that is)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new way to load a development module.
This will serve as a backup method in the future.
Allows developers to load a module directly from a libpath.
This means they can use Rstudio to build the module and its dependencies.
For example:
renv::activate() renv::restore() renv::install('.') .libPaths()This will install a jasp module using renv and provide a libpath to give to jasp to load the module from. The libpath and name need to be specified in a new textboxes in the advanced settings menu.
Added ways to manually reload module using:
CTRL+SHIFT+D (reloads entire module)
CTRL+SHIFT+U (reloads only QML UI)
CTRL+SHIFT+R (reloads only R, reruns analysis but keeps current set options)
button in modules module to reload entire module
To get this to work on Mac we copy the libpath to tmp folder and do the otoolstuff patch magic that is now found in common/