Fix filter crash #5720
Merged
Fix filter crash #5720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug happened where if you entered in new data: (one by one) column1, "c", "1" column2, "2" the engine would crash because of some bad housekeeping of data... this is because labelsAdd was used which checks the valDisMap and then doesnt really add anything. The db was iterating over rows though... But ive now replaced it with column->labelsSet. It takes the honor of either adding a label or overwriting one on a particular place. And adds them to the also freshly cleaned valDisMap and intsIdMap. Also, try not to resize the labels to be bigger then it needs to be to avoid all those 0pointer exceptions 😿
JorisGoosen
force-pushed
the
fixCrashDuringFilter
branch
from
b662635 to
41e1e22
Compare
… do it atomically
boutinb
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug happened where if you entered in new data:
(one by one)
column1, "c", "1"
column2, "2"
the engine would crash because of some bad housekeeping of data...
this is because labelsAdd was used which checks the valDisMap and then doesnt really add anything.
The db was iterating over rows though...
But ive now replaced it with column->labelsSet.
It takes the honor of either adding a label or overwriting one on a particular place.
And adds them to the also freshly cleaned valDisMap and intsIdMap.
Also, try not to resize the labels to be bigger then it needs to be to avoid all those 0pointer exceptions 😿