Encode rowValue of a componentList when it contains variables #5723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorisGoosen
approved these changes
Oct 29, 2024
| columnTypeVec coTypes = combos.at(j).types(); | ||
| types.insert(types.end(), coTypes.begin(), coTypes.end()); | ||
|
|
||
| Term newTerm(termComponents); |
There was a problem hiding this comment.
Why not expand the constructor?
| @@ -81,7 +84,7 @@ class Term | |||
| QStringList _components; | |||
| QString _asQString; | |||
| bool _draggable = true; | |||
| columnType _type = columnType::unknown; | |||
| columnTypeVec _types = {columnType::unknown}; | |||
There was a problem hiding this comment.
_types should be settable in the constructor (and can then have `columnType::unknown' as the default argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MixedModels analyses do not work because the random effects ComponentsList has for source the "Random effects grouping factors" Variables List. So the rowValue of the componentsList (the key of a row in the ComponentsList) is a variable (with possible interactions), and it must be also encoded with the right type.
For this the Term object should contain not only the type when it is a single variable, but also the types of each interaction when it contains several variables.
Another test has been added in the jaspTestModule encoding analysis.
NB: The Mixed Models still do not work after this fix, but @FBartos knows why. He needs first this fix to be able to fix completely the Mixed Models.