Better handling of labeleditor for computed columns #5727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if computed column is scale it will interpret values given as values and thus keep labels otherwise its the opposite for jasp-stats/INTERNAL-jasp#2680
also make sure that it will update the generated filter for labels after a computed column is updated and make sure the labelfiltergenerator actually compares with labels (also for scale columns)
…double labels by Label after all
JorisGoosen
force-pushed
the
computedColumnReadOnlyLevelEditColumns
branch
from
c216ac9 to
42d471e
Compare
…sorting we should really just replace everything by Label
…reducing code duplication Also make sure the label isnt overwritten by changing the value in the case of a nonscale computed column
boutinb
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now computed columns handle the data they get based on their type, which means that:
If the corresponding value/label is missing it just uses the label/value it got.
This is all made clear to the user by the column in the labeleditor not being editable.
Ive also made sure that you can also filter by clicking labels out. I noticed a small bug where if the computed column is a scale it wont actually filter properly, so ive made sure that each column used in the label-filter-thing (generatedFilter) is always read as nominal and that solves that.
Fixes and or implements https://github.com/jasp-stats/INTERNAL-jasp/issues/2680
There also seemed to be an issue with the autosort but that was easily fixed by just generating
Labelfor each (double-type) label.