Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the right implicit empty values in tooltip #5747

Merged
merged 5 commits into from
Nov 28, 2024

Conversation

boutinb
Copy link
Contributor

@boutinb boutinb commented Nov 28, 2024

If you set a nominal or ordinal variable in a scale VariablesList, a tooltip tells you how the values are transformed into scale. It gives also a list of 'implicit' empty values: that is the not empty values that could not be converted into a double value. This list was not correct, it gave all the convertable values.

If you set a nominal or ordinal variable in a scale VariablesList, a tooltip tells you how the values are transformed into scale.
It gives also a list of 'implicit' empty values: that is the not empty values that could not be converted into a double value. This list was not correct, it gave all the convertable values.
@JorisGoosen
Copy link
Contributor

Could you give me an example of the problem and how this solves it?
Because Ive been looking in my nightly for weird tooltip with "wrong" info and cant see it?

@boutinb
Copy link
Contributor Author

boutinb commented Nov 28, 2024

This is what I got with this test:
Screenshot 2024-11-28 at 12 11 57

@boutinb
Copy link
Contributor Author

boutinb commented Nov 28, 2024

And this is what I get after my fix:
Screenshot 2024-11-28 at 12 14 52

@boutinb
Copy link
Contributor Author

boutinb commented Nov 28, 2024

Here are my file:
simple.csv

also make sure empty values are also checked on the original value now
@JorisGoosen JorisGoosen self-requested a review November 28, 2024 16:31
@JorisGoosen
Copy link
Contributor

@boutinb I think the double check should be on the value, not the label.

@boutinb boutinb merged commit aef9532 into jasp-stats:development Nov 28, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants