Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropDown width issues solved #5753

Merged
merged 8 commits into from
Dec 6, 2024
Merged

Conversation

boutinb
Copy link
Contributor

@boutinb boutinb commented Dec 4, 2024

Check test DropDown in jaspTestModule

The fieldWidth property gives the width of the internal dropdown control. If this property is set, it fixes the width. This feature is needed, especially when DropDown controls are used in a ComponentList, where the width of the controls should not changed with the values of the dropdown.

This is also needed to solves some problem in PR jasp-stats/jaspProcess#108

@boutinb boutinb requested a review from JorisGoosen December 4, 2024 17:18
In the Effect Size Computation of the Meta Analysis module, the dropdowns in a ComponentList depends on each other for their values.
TO solve this, just use the _unusedInitialValue.
Copy link
Contributor

@JorisGoosen JorisGoosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You see them now then?

QMLComponents/components/JASP/Controls/ComboBox.qml Outdated Show resolved Hide resolved
QMLComponents/components/JASP/Controls/ComboBox.qml Outdated Show resolved Hide resolved
QMLComponents/controls/comboboxbase.h Outdated Show resolved Hide resolved
@shun2wang shun2wang self-requested a review December 5, 2024 15:06
Copy link
Contributor

@shun2wang shun2wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DropDown now works well for me.

@boutinb
Copy link
Contributor Author

boutinb commented Dec 6, 2024

Should we merge it @JorisGoosen ?

@boutinb boutinb merged commit 9d3e69b into jasp-stats:development Dec 6, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants