Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Variable Name with Japanese is truncated opening a ods file #2789

Closed
3 tasks done
momoldo opened this issue Jun 20, 2024 · 11 comments · Fixed by jasp-stats/jasp-desktop#5703
Closed
3 tasks done
Assignees
Labels
Bug: Medium Bugs that don't influence the basic function of the app, but it's better to fix them at some point. OS: macOS Silicon

Comments

@momoldo
Copy link

momoldo commented Jun 20, 2024

JASP Version

0.18.3

Commit ID

No response

JASP Module

Unrelated

What analysis are you seeing the problem on?

No response

What OS are you seeing the problem on?

macOS Silicon

Bug Description

I attempted this ods file to JASP.
image

This is a result opend in JASP
image

The name of the fifth variable consists five Kanji characters, but after opening in JASP, this consists three Kanji characters.
This situation don't happen when I open csv file. It's not a serious problem, but kanji characters in a csv file sometimes happen another problem when it opened.

Expected Behaviour

It is not serious. If it is easy to repair, I need to repair the problem.

Steps to Reproduce

I can't recognize what kanji character happens this problem.

Log (if any)

No response

Final Checklist

  • I have included a screenshot showcasing the issue, if possible.
  • I have included a JASP file (zipped) or data file that causes the crash/bug, if applicable.
  • I have accurately described the bug, and steps to reproduce it.
@momoldo momoldo added the Bug label Jun 20, 2024
@tomtomme tomtomme added Bug: Medium Bugs that don't influence the basic function of the app, but it's better to fix them at some point. and removed Bug labels Jun 20, 2024
@boutinb
Copy link
Contributor

boutinb commented Jun 20, 2024

@shun2wang did you ever have this problem?

@shun2wang
Copy link
Contributor

I didn't saw this problem,.@momoldo could you please share your .ods file and we will have a look?

@momoldo
Copy link
Author

momoldo commented Jun 20, 2024

Thank you for your reply.

This file causes this problem...
小売価格2020年6月.ods

I'm checking if another ods file causes same problem.
This file "testfile.ods" is no problem.
testfile.ods

Do this file "testfile2.ods" causes problem?
testfile2.ods

@momoldo
Copy link
Author

momoldo commented Jun 20, 2024

"珈琲" is something wrong.

Testfile3.ods hos three variables "追手門学院大学", "コメダ珈琲" and "珈琲Shop".
testfile3.ods

The name of the second variable changes "コメダ" and the third changes "珈琲".
Is "珈琲" a naughty word?

@shun2wang
Copy link
Contributor

shun2wang commented Jun 23, 2024

yeah, confirmed this is a importing ods problems, if rows names in text:p then we read them as names. because we read xml depth at text:p, seems libreOffice/MS-Office will merge them and ignore ruby-xxx?

see:

<table:table-cell office:value-type="string" table:style-name="ce2">
    <text:p>
        <text:ruby text:style-name="ru1">
            <text:ruby-base>喫茶店</text:ruby-base>
              <text:ruby-text text:style-name="T5">キッサテン </text:ruby-text>
              </text:ruby>
        <text:ruby text:style-name="ru1">
            <text:ruby-base>珈琲</text:ruby-base>
            <text:ruby-text text:style-name="T5">コーヒー </text:ruby-text>
        </text:ruby>
    </text:p>
</table:table-cell>

and

<table:table-cell office:value-type="string" table:style-name="ce2">
    <text:p>
        <text:ruby text:style-name="ru1">
            <text:ruby-base>都市名</text:ruby-base>
            <text:ruby-text text:style-name="T5">トシメイ </text:ruby-text>
       </text:ruby>
    </text:p>
</table:table-cell>

@momoldo
Copy link
Author

momoldo commented Jun 25, 2024

Thank you for your job!
I understood it.

@JorisGoosen
Copy link
Contributor

JorisGoosen commented Oct 16, 2024

afbeelding

Is what I see when I open it in libre office on my system, where it doesnt even show anything in the headers?
(This is after opening the file linked above)

@shun2wang
Copy link
Contributor

shun2wang commented Oct 16, 2024

It's OK for me on Linux/Window in LibreOffice:
image

Even MS-Excel on Windows is OK, maybe a bug from LibreOffice on MacOS.

@JorisGoosen
Copy link
Contributor

JorisGoosen commented Oct 17, 2024

This is weird, also if I load it in google-docs:
image

(But I dont have access to a windows or linux machine for a few days)

@JorisGoosen
Copy link
Contributor

都市名 | マグロ | ジャガイモ | 喫茶店珈琲 | 民営家賃 | 水道料金

is what it gets loaded as on linux, looking like boxes...
Does ods have some weird encoding settings that we dont know about?

@JorisGoosen
Copy link
Contributor

This issue might be solved by the PR jasp-stats/jasp-desktop#5703 but there might be some strange issues with such characters in ods. Not sure whats up, but if it works on Shun and momoldo's systems I guess it works where it needs to.

@tomtomme tomtomme added the Waiting for requester If waiting for a long time it is reasonable to close an issue label Oct 22, 2024
@shun2wang shun2wang removed the Waiting for requester If waiting for a long time it is reasonable to close an issue label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Medium Bugs that don't influence the basic function of the app, but it's better to fix them at some point. OS: macOS Silicon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants